azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.41k stars 2.56k forks source link

Escort Quests cannot be completed by others group members (Generic Issue). #19591

Open Rorschach91 opened 1 month ago

Rorschach91 commented 1 month ago

Current Behaviour

Escort quests can be completed without problems when you are alone. But if you do these type of quest when you are in a group, only who starts the quest can complete it, other group members are not able, and They must restart them, doing alone (even if they accept the quest).

I decided to make this issue because I already found two issues on CC that report this type of problem and I personally encountered this problem while playing.

I will link reports regarding escort quest on CC directly in this Issue.

CC Report 1: https://github.com/chromiecraft/chromiecraft/issues/5654#issue-1718925404 CC Report 2: https://github.com/chromiecraft/chromiecraft/issues/5655#issue-1718928592 CC Report 3: https://github.com/chromiecraft/chromiecraft/issues/6225#issue-1938944886 This is another quest that has the same problem: Escape from the Winterfin Caverns. Already tested by me.

Expected Blizzlike Behaviour

Party members that accept through the pop-up should have their quest completed normally.

Source

No response

Steps to reproduce the problem

  1. Begin quest in a party of at least two.
  2. Observe that the party member who accepted via the pop-up, the quest does not complete in their quest log.

Extra Notes

No response

AC rev. hash/commit

https://github.com/chromiecraft/azerothcore-wotlk/commit/8224a90a99cc40ff9a7a9a3ab4d7aecc40aacd3d

Operating system

Windows 11

Custom changes or Modules

No response

heyitsbench commented 1 month ago

I do believe this is a sort of issue that needs to be corrected case by case, e.g. changing SmartAI target type from invoker to invoker party.

icemansparks commented 1 month ago

Another quest that is affected by this is an escort quest in Netherstorm: quest ID 10191

Nyeriah commented 3 weeks ago

I do believe this is a sort of issue that needs to be corrected case by case, e.g. changing SmartAI target type from invoker to invoker party.

This, actually, there's a different action to give credit to those (GroupEventHappens or something)