azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.48k stars 2.59k forks source link

[DB] at_login=4 #19753

Open manstfu opened 1 month ago

manstfu commented 1 month ago

Current Behaviour

Setting at_login 4 while having dual spec, reset only active spec talents, i think it should reset both spec talents.

Expected Blizzlike Behaviour

Not sure

Source

No response

Steps to reproduce the problem

set at_login 4 to a character that has dual specialization

Extra Notes

No response

AC rev. hash/commit

rev. 83f8871c31fd

Operating system

Debian 12

Custom changes or Modules

No response

noisiver commented 1 month ago

This says otherwise: https://gamefaqs.gamespot.com/boards/534914-world-of-warcraft/58107270

It doesn't even make sense if it reset both anyway. If you wanted to switch your secondary spec to another spec you'd have to set the talents for your primary spec again which would make it a royal pain to deal with.

manstfu commented 1 month ago

You are right! close this issue please!

heyitsbench commented 1 month ago

I think this flag only ever gets set on Blizz servers with an expansion change, i.e. when talent trees get overhauled, at which point I think it does make sense to reset both trees. Obviously a manual respec done in-game by the player should only reset the active specialization, but I'd think the at_login flag should reset both.

manstfu commented 1 month ago

I think this flag only ever gets set on Blizz servers with an expansion change, i.e. when talent trees get overhauled, at which point I think it does make sense to reset both trees. Obviously a manual respec done in-game by the player should only reset the active specialization, but I'd think the at_login flag should reset both.

Yea, thats what i was thinking when i create this issue, this flag should be used as a 'urgent method/debug method' and not as a 'service' also this flag should clear all spells in character_spell with specMask 0 and 1 excluding specMask 255

Thats the list with all spell's id that needs to be cleared from character_spell

https://github.com/azerothcore/tool-tc-migration/blob/8c3628dce82ef2dc98f0fc7d7bf7f36929a82851/1_CREATE_CLEANUP_TABLES.sql#L798