Crash! (Some Kind of Memory Leak)

[PadreWoW]

Current Behaviour

Just go to https://www.wowhead.com/wotlk/quest=12416/heated-battle Start attack Frigid Abomination Attacker (https://www.wowhead.com/wotlk/npc=27531/frigid-abomination-attacker) or any mob there After some time the server will go down The problem is intermittent and does not always reproduce. MaxCoreStuckTime = 10

I think, the problem is here: https://github.com/azerothcore/azerothcore-wotlk/commit/c929b95172c88d5257077dbbdebb9ca8fabbad26

fa1f49be1a2dworldserver.exe[13-9_14-11-37].dmp

Expected Blizzlike Behaviour

Should not crash

Source

No response

Steps to reproduce the problem

MaxCoreStuckTime = 10

1) Just go to https://www.wowhead.com/wotlk/quest=12416/heated-battle 2) Start attack Frigid Abomination Attacker (https://www.wowhead.com/wotlk/npc=27531/frigid-abomination-attacker) 3) After some time the server will go down

Extra Notes

No response

AC rev. hash/commit

https://github.com/azerothcore/azerothcore-wotlk/commit/d5263b0aee18b825ff7f46fb861094ff1836693e

Operating system

WinServ 2019

Custom changes or Modules

mod_transmog mod_learnspell mod_anticheat

[heyitsbench]

Cannot reproduce. Please upload the actual crashlog instead of the dump file (.txt, not .dmp) to a gist.

[PadreWoW]

https://gist.github.com/PadreWoW/6354e96ccc2ef4bdc44566496100d596

[heyitsbench]

No memory leak, result of https://github.com/azerothcore/azerothcore-wotlk/commit/edd7e10dfc7651ed2657a09d5411771831c8ec1e.

[PadreWoW]

No memory leak, result of edd7e10.

You found problem?

[hermensbas]

No memory leak, result of edd7e10.

Not sure thats the cause of the above problem, but we had to revert that commit as it caused nonstop crashes during init on the playerbot branches. Reference bug <- contains debug information

[heyitsbench]

The crashlog provided is not using a valid AC revision. Please retest with a clean AC.

[PadreWoW]

Problem was really here edd7e10.

No crash after revert this commit Many thanks

[Nyeriah]

That you found the solution to your problem doesn't mean its fixed

[heyitsbench]

I am unable to reproduce this crash/hang on a clean AC. If anyone is able to do so, please provide steps.

[PadreWoW]

I am unable to reproduce this crash/hang on a clean AC. If anyone is able to do so, please provide steps.

I am able to catch this crash only on Warrior (Fury-Arms) - gear on screenshot above

[heyitsbench]

Yes, I can see from the crashlog that the spell causing the issue is Deep Wounds, but I've tested with Deep Wounds and it's causing no issues for me.

[PadreWoW]

Yes, I can see from the crashlog that the spell causing the issue is Deep Wounds, but I've tested with Deep Wounds and it's causing no issues for me.

Just use this build: https://www.wowhead.com/wotlk/ru/talent-calc/warrior/0502030123-305050130525010250120501351 And my gear Do not use only deep wounds - use all abilities And the probability of getting a crash increases if you hit many mobs at once (I use Berserker Stance and Whirlwind + Cleave)

[heyitsbench]

Tested as you said, still no crash.

[hermensbas]

The crashlog provided is not using a valid AC revision. Please retest with a clean AC.

Tried wasnt able too

[PkllonG]

Problem was really here edd7e10.

No crash after revert this commit Many thanks

me too

[kissingers]

https://pastebin.com/Vt6fNUrH Me too Crash. and after revert this no problem. my branch is npcbots

[kissingers]

0x0000555556386fce in Unit::CastCustomSpell (this=this@entry=0x7fff7af21000, spellId=spellId@entry=12654, value=..., victim=victim@entry=0x7fff7a6c0000, triggerFlags=triggerFlags@entry=TRIGGERED_FULL_MASK, castItem=castItem@entry=0x0, triggeredByAura=, originalCaster=...)

before triggeredByAura always triggeredByAura@entry=0x0 and now triggeredByAura=

then crash.

might aurEff here direct change to nullptr to keep same as before? caster->CastCustomSpell(spellId, SPELLVALUE_BASE_POINT0, addAmount, this, TriggerCastFlags(TRIGGERED_FULL_MASK & ~TRIGGERED_NO_PERIODIC_RESET), nullptr, aurEff, caster->GetGUID());

[walkline]

I bet that aura effect lifetime is less than AuraMunchingQueue.

[heyitsbench]

For those experiencing the crash, please give https://github.com/azerothcore/azerothcore-wotlk/pull/19977 a try.