azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.62k stars 2.64k forks source link

[Shadowmoon Valley - Quest] The Fel and The Furious. Various Problems. #19993

Open Rorschach91 opened 2 months ago

Rorschach91 commented 2 months ago

Bug Triager Notes:

Original CC Report: https://github.com/chromiecraft/chromiecraft/issues/7356#issue-2518825749

Old Reports Regarding this quest: https://github.com/azerothcore/azerothcore-wotlk/issues/15035 https://github.com/azerothcore/azerothcore-wotlk/issues/3605

There are several problems with this quest. Some of them are showed in two old reports.

Issues:

1) When you controll Fel-Reaver you can target other Fel-Reavers as ostile npcs, but you cannot damage them (you shouldn't be able to target them. Probably they shouldn't be hostile when you controll one of them.). 2) If you go a little far from your controlled Fel-Reaver's spawn point, controll will interrupt. 3) If controll stopped, Fel-Reaver will not return to its spawn point, and sometimes It will attack you. 4) The button n 1 has been replaced with auto-attack spell. It should have a spell button that destroy Deathforged Infernals (this is the news). 5) It seems that "Deathforged Infernal Destroyed 0/60" script is missing from the quest log.

How it should works: Youtube How Currently works on CC/AC: Youtube


What client do you play on?

enUS

Faction

Horde

Content Phase:

70

Current Behaviour

Deathforge infernals you are supposed to kill are untargetable and can't be killed.

Expected Blizzlike Behaviour

Supposed to be able to target the deathforged infernals and use fel reaver ability on them to kill them

Source

I have no sources

Steps to reproduce the problem

  1. accept quest
  2. Take over fel reaver
  3. attempt to kill Deathforged Infernals with fel Reaver abilities

Extra Notes

No response

AC rev. hash/commit

https://github.com/chromiecraft/azerothcore-wotlk/commit/fafd351e44b4556b9ceda4bfaa72c6e5f22c3f78

Operating system

Ubuntu 22.04

Modules

Customizations

None

Server

ChromieCraft

Rorschach91 commented 1 month ago

The button n 1 has been replaced with auto-attack spell. It should have a spell button that destroy Deathforged Infernals (this is the news).

This problem is also present on The Eye of Acherus.

sogladev commented 3 weeks ago

Some of the listed problems are no longer present from my testing

  1. [x] The button n 1 has been replaced with auto-attack spell. It should have a spell button that destroy Deathforged Infernals (this is the news).

fixed with

  1. [x] It seems that "Deathforged Infernal Destroyed 0/60" script is missing from the quest log.

this works with previous mentioned PR enabling the button

sogladev commented 3 weeks ago

Are the unit_flags=0 for 19400 Fel Reaver Sentinel correct? Missing IMMUNE_TO_PC, IMMUNE_TO_NPC could fix the issues below. Currently, reaver uses a smartAI hack to evade when in combat.

  1. [ ] When you controll Fel-Reaver you can target other Fel-Reavers as ostile npcs, but you cannot damage them (you shouldn't be able to target them. Probably they shouldn't be hostile when you controll one of them.).
  2. [ ] If controll stopped, Fel-Reaver will not return to its spawn point, and sometimes It will attack you.

The below looks to be an issue for every controlled NPC with SPELL_AURA_MOD_POSSESS. The aura gets removed once out of reach of map visibility (90.0f) of SMV https://github.com/azerothcore/azerothcore-wotlk/blob/99e6249922de850f60e1e3fecd9c3ee8a9063bc9/src/server/game/Entities/Creature/Creature.cpp#L771

  1. [ ] If you go a little far from your controlled Fel-Reaver's spawn point, controll will interrupt.