azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.55k stars 2.62k forks source link

Kara - Opera Event - Strawman #20026

Open alecsci opened 1 month ago

alecsci commented 1 month ago

Current Behaviour

Reported by: https://github.com/chromiecraft/chromiecraft/issues/6155 When using fire there against Strawman there is a low chance to be disoriented

Expected Blizzlike Behaviour

Every last/high fire rank spell should insta disorient him

Source

https://wowpedia.fandom.com/wiki/Strawman

Burning Straw — Chance to be disoriented for 6 seconds whenever hit by a fire spell.

https://www.wowhead.com/tbc/npc=17543/strawman#comments:id=222780

Steps to reproduce the problem

  1. tele kara
  2. kill Moroes
  3. go to Opera
  4. .gm on and select the Oz event
  5. start event
  6. learn any fire spell (.learn 27074)
  7. cast against strawman

It took me 10 hits to get him feared once

Extra Notes

https://github.com/azerothcore/azerothcore-wotlk/pull/17307

AC rev. hash/commit

014602c849a3310bdae6feda8f6fd695878f1eb5

Operating system

Windows 11 x64

Custom changes or Modules

None

Zoidwaffle commented 1 week ago

The scripting is here: ./src/server/scripts/EasternKingdoms/Karazhan/bosses_opera.cpp

Seems like it's set to 10% chance from any fire attack, not just direct highest rank ones (as it should be). This is also true for TtrinityCore: https://github.com/TrinityCore/TrinityCore/blob/master/src/server/scripts/EasternKingdoms/Karazhan/bosses_opera.cpp

I was unable to find a nice video that shows the expected chance to trigger "Burning Straw".

Unfortunately I don't know how to rewrite it and even if I did, no idea about the chance...