azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.62k stars 2.64k forks source link

[NPC/World] - Certain NPC (if not all). Do not move after being interacted with #20721

Open TheSCREWEDSoftware opened 1 day ago

TheSCREWEDSoftware commented 1 day ago

Current Behaviour

If you talk to any npc that has an interaction, like a gossip, they will stop and stay there until a server restart.

Expected Blizzlike Behaviour

After the interaction is done, for them to eventually move.

Source

N/A

Steps to reproduce the problem

For alliance, at the start of the server / loading the area.

For horde, at the start of the server / loading the area.

Extra Notes

Reported by atlas ( iatlas |155066684774940674 ) in Discord

image

AC rev. hash/commit

AzerothCore rev. f14edcbdc90c

Connected players: 2. Characters in world: 2.
Connection peak: 2.
Server uptime: 48 minute(s) 22 second(s)
Update time diff: 2ms. Last 500 diffs summary:
|- Mean: 2ms
|- Median: 2ms
|- Percentiles (95, 99, max): 4ms, 4ms, 4ms
Using SSL version: OpenSSL 3.1.5 30 Jan 2024 (library: OpenSSL 3.1.5 30 Jan 2024)
Using Boost version: 1.81.0
Using CMake version: 3.29.3
Using MySQL version: 80036
Found MySQL Executable: C:/Program Files/MySQL/MySQL Server 8.0/bin/mysql.exe
Compiled on: Windows
Worldserver listening connections on port %hu
Realmlist (Realm Id: 1) configured in port 8085
VMAPs status: Enabled. LineOfSight: true, getHeight: true, indoorCheck: true
MMAPs status: Enabled
maps directory located in ./Data/maps. Total size: 291014951 bytes
vmaps directory located in ./Data/vmaps. Total size: 658130721 bytes
mmaps directory located in ./Data/mmaps. Total size: 2192910844 bytes
Default DBC locale: enUS.
All available DBC locales: enUS
Using World DB: ACDB 335.12-dev
Latest LoginDatabase update: 2024_11_15_00.sql
Latest CharacterDatabase update: 2024_11_15_00.sql
Latest WorldDatabase update: 2024_11_22_03.sql
LoginDatabase queue size: 0
CharacterDatabase queue size: 0
WorldDatabase queue size: 0
No modules are enabled

Operating system

Windows 10 x64

Custom changes or Modules

None

Grimdhex commented 1 day ago

Need to take care because some behaviour are voluntary. It looks strange but for example guards of stormwind or others npcs in Elwyn have the same behaviour. I was checked on retail and classic, all is correct. I don't know why blizzard do this choice.

Need to check for npcs reported.

TheSCREWEDSoftware commented 1 day ago

Having patrols creatures that stop until restart doesn't sound something normal, I can go check same behaviour in retail or either cata classic or vanilla classic and make a video comparing. Sometimes npcs do stop for a bit, which is fine

xeonatlas commented 1 day ago

Having patrols creatures that stop until restart doesn't sound something normal, I can go check same behaviour in retail or either cata classic or vanilla classic and make a video comparing. Sometimes npcs do stop for a bit, which is fine

Yes, it seems random, no adjustment of the and no adjustment of the Creature.MovingStopTimeForPlayer or WaypointMovementStopTimeForPlayer options makes any difference either.

But if this is actually intentional, it's such a strange decision.

Grimdhex commented 1 day ago

During my tests, I waited 5min without restart from npcs . It's maybe more longer. So need to investigate on it's really work.

TheSCREWEDSoftware commented 1 day ago

Sorry @Grimdhex i'm having a hard time understanding your comment. Did you encounter the issue?

Edit:

I will leave two videos with a side-by-side, at the first frame before the gossip menu appears. And has chapters, divided 2. 1 from the start to the end of the fatest npc to move and the second is the one that doesn't move.

Left it's Blizzard Classic-Classic (Vanilla) and Right it's AzerothCore. While the tests were made with less than 10 minutes. Until 30 minutes I gurantee they do not move.

Grimdhex commented 22 hours ago

On AC npc doesn't restart to move. I can confirm this also.

Thanks you a lot for videos. the only bad news is the time to start moving again seems to not be the same for all npcs. And probably a min/max system. As I said before, I hadn't observed anything after 4/5min a while ago.

xeonatlas commented 19 hours ago

Thanks for confirming this, hopefully on the path to fix, I tried running my build in debug mode but no so sure this is actually going to throw errors of any kind.

Grimdhex commented 16 hours ago

Thanks for confirming this, hopefully on the path to fix, I tried running my build in debug mode but no so sure this is actually going to throw errors of any kind.

There are no errors or bugs. It's just that interacting with an NPC interrupt and finish their path. Need to implement a pause instead.