azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.63k stars 2.65k forks source link

[Warrior] Recklessness + Juggernaut causes non-critical mortal strike/slam hits to occur #20741

Open Annamaria-CC opened 5 days ago

Annamaria-CC commented 5 days ago

What client do you play on?

enUS

Faction

Both

Content Phase:

Generic

Current Behaviour

Talent Juggernaut should stack with Recklesness buff. Therefore there should be 100% to crit on next Mortal Strike/Slam. That isn't the case as non-crit Mortal Strike/Slam can happen.

Expected Blizzlike Behaviour

Juggernaut 25% + Recklesness 100% should stack Therefore Mortal strike non-crits shouldn't ever occur.

In that case Juggernaut and 1 stack of Recklesness is consumed - that part works if Mortal strike crits.

Source

Wrath Classic

Steps to reproduce the problem

  1. Cast Recklesness
  2. Charge with Juggernaut talent
  3. Use Mortal Strike
  4. If it doesn't crit, thats an issue

Extra Notes

original reported: https://github.com/chromiecraft/chromiecraft/issues/5042 Could find any weird reports on this for retail.

AC rev. hash/commit

https://github.com/chromiecraft/azerothcore-wotlk/commit/8224a90a99cc40ff9a7a9a3ab4d7aecc40aacd3d

Operating system

Ubuntu 20.04

Modules

Customizations

None

Server

ChromieCraft

TheSCREWEDSoftware commented 5 days ago

It's this a linked post from cc?

Edit: nvm phone makes some links so hard to see...

Reily93 commented 4 days ago

i copy past there cause old one seems closed

k now i see the issue, let me grab some videos , but what happen atm is the following: if u have recklessness up and u charge and u proc juggernaut only juggernat get consumed cause the buffs dont stack togheter

what should happen(i will check for video proof but im 100% sure) when u use recklessness and then charge both buff ( wich in the tooltip says addional crit) should stack togheter and get consumed togheter so if i use mortal strike while i have juggernaut and recklessness up both should be consumed (recklessness 1 stack of 3)

video proof https://www.youtube.com/watch?v=9YBxx0GiRuM minute 8:59 he uses recklessness followed by charge--->mortal strike (crit) if u notice both recklessness (1stack of 3--2/3) and juggernaut get consumed

both recklessness and juggernaut should put u above the 100% crit as i happen for block value when u use it and cause both says additional u should reach if ur base crit is 40%+100(reck)+25(juggernaut that only increase mortal and slam) around 165% crit that cause when u pvp resilence gonna decrease ur crit chance, so to be sure it dosent remove reckless ness from crit they should stack

Reily93 commented 4 days ago

So now 2 ipothetical scenarios open if both buffs are on :

A juggernaut get rolled for crit and fail-- 1 stack of recklessness get consumed to assure the crit of mortalstrike/slam

B juggernaut get rolled for crit and success (mortalstrike )- no recklessness stack get consumed (3/3)