azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.5k stars 2.61k forks source link

[3.3.5] Core/loot/exploit the loot is not linked to players inside the dungeon or raid [$15] #2104

Closed w5860363 closed 3 years ago

w5860363 commented 5 years ago

Current behaviour: Players outside instance are still entitled to trophies Expected behaviour: Only the players involved in the battle have the trophies Steps to reproduce the problem: Two Player Groups One of the entry instances .die boss Players who do not enter instance enter instance Players pick up trophies Players who do not participate in instance can still see the trophy list ROUND and group or master loot Another player point does not save instance to leave Branch: Master. AC hash/commit: 7b105b7 Operating system: Linux, Ubuntu 14.04 and Windows 7. Modules: No. Other Customizations: No.

--- There is a **[$15 open bounty](https://www.bountysource.com/issues/77081861-3-3-5-core-loot-exploit-the-loot-is-not-linked-to-players-inside-the-dungeon-or-raid?utm_campaign=plugin&utm_content=tracker%2F40032087&utm_medium=issues&utm_source=github)** on this issue. Add to the bounty at [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F40032087&utm_medium=issues&utm_source=github).
w5860363 commented 5 years ago

https://github.com/TrinityCore/TrinityCore/issues/7672

ELdoBA commented 5 years ago

Doesn't mean if the TC has this issue, we have it too. This need to be checked first, here are steps from TC :

Go attack first boss in ICC with 10 man raid: Lord Marrowgar http://www.wowhead.com/npc=36612 -

When boss has 1% HP stop damage and leave the raid (but still stay in instance - 60 seconds timer limit is set before it kicks you out)

When noone is in the raid kill the boss and quickly create the raid inside instance again

All players have loot and no ID! and can do this again and again

w5860363 commented 5 years ago

PR has been performed on the latest submission The second player enters the duplicate after the death of BOSS. The first player picks up trophies. There will still be loot lists. PR Sunwell just blocked freeloot

disclosurez commented 4 years ago

there is no fix or PR for this?

w5860363 commented 4 years ago

@disclosurez https://github.com/TrinityCore/TrinityCore/issues/7672

Helias commented 4 years ago

@Rushor did you solve this issue? Could you open a PR for this?

disclosurez commented 4 years ago

@Rushor did you solve this issue? Could you open a PR for this?

the fix mentioned in the above does not fix this problem

disclosurez commented 3 years ago

bump, still possible and very annoying

mpfans commented 3 years ago

@UltraNix thanks