azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.46k stars 2.59k forks source link

[Translation] Missing deDE quest Locales #2346

Closed LukasVolgger closed 4 years ago

LukasVolgger commented 4 years ago
SMALL DESCRIPTION:

Nearly all quest texts of the request items and the offer rewards are not translated in german.

EXPECTED BLIZZLIKE BEHAVIOUR:

Wow deDE Client should be able to use all german quest texts.

CURRENT BEHAVIOUR:

Missing deDE Locales in the following db tables:

STEPS TO REPRODUCE THE PROBLEM:
  1. Add any quest
  2. get the required stuff (Requested items)
  3. End the quest (Offer rewards)
EXTRA NOTES:

Using Azerothcore Solo Repack from Brookstech

BRANCH(ES):

master

AC HASH/COMMIT:

d2b409e77ed0+ 2019-06-15 11:51:37 -0500

OPERATING SYSTEM:

Windows 10 Home Premium

MODULES:
OTHER CUSTOMIZATIONS:
quilumipe commented 4 years ago

the same happens with the other locales like spanish and french

LukasVolgger commented 4 years ago

@BarbzYHOOL I found a translated DB and wan't to edit the tables to our DB Structure an then test to import.

What does the first column with an int in the table 'quest_offer_reward_locale' mean?

Helias commented 4 years ago

immagine

If you mean ID for first column, it's just the ID of the Quest. Locale is the local language.

Anyway I just checked the DB, there are 1700 deDE quests and 44 esES quests, so several quests language are missing.

LukasVolgger commented 4 years ago

Ah Sry i meant the 'VerifiedBuild' @Helias. The ID is clear what it does :D

LukasVolgger commented 4 years ago

@Helias

I found some sql files from the GTDB project on Github https://github.com/gpn39f/GTDB where a lot of quests where i noticed they are not translated are stored.

Could you have a look at it?

Helias commented 4 years ago

Sure. :+1:

Helias commented 4 years ago

There are several contents in GTDB, but it is for a old TrinityCore version, so we need to convert the sql structure into our and than import the sql.

LukasVolgger commented 4 years ago

Exactly, i already worked a little bit on the structure of the sql so that i fit's to our db but i can't get further with my SQL knowledge πŸ˜“

Definitely the request item and offer reward texts are needed, some objectives too but i will check this later...

If you could prepare it then i would test them πŸ‘πŸ»

Helias commented 4 years ago

Ok, I don't know if I will find the time in this week, hope so, I will update you :wink:

LukasVolgger commented 4 years ago

Thx πŸ‘πŸ»πŸ˜

Helias commented 4 years ago

The GTDB is still incomplete, like "Work in progress", the project probably stopped 6 years ago.

I imported the followings table and related data, I removed the duplicates data:

(the number in parentheses is the number of rows imported).

I don't know the correspond table in AC for:

TODO: quest_template_locale

I'm working on it, I will finish this last table and make the PR.

Helias commented 4 years ago

locales_quest done.

Imported the data and distributed into the following tables:

LukasVolgger commented 4 years ago

Nice, you saved my Weekend✌🏻 I will check it out in a few hours, i noticed every non-translated quest i ever made πŸ˜…πŸ™ˆ

Helias commented 4 years ago

PR opened, feel free to check the SQL file :wink: