search

azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.59k stars 2.64k forks source link

[Core/Spells] Spell hitbox #2827

Open hguy23 opened 4 years ago

hguy23 commented 4 years ago
SMALL DESCRIPTION:

There is a problem with spell like holy nova, arcane blast and such others making player's untargetable.

EXPECTED BLIZZLIKE BEHAVIOUR:

Creature and player's should be targetable after casting spell's on creature or player.

CURRENT BEHAVIOUR:

Creature's and player's are un-targetable for etc. 1 sec (aprox when hitbox of spell is done)

STEPS TO REPRODUCE THE PROBLEM:
  1. Make 2 player's A and B
  2. Player A is priest and cast holy nova on any creature or player
  3. After cast, player B can't target for 1 sec creature or player (Attack Sword icon in client dissapear)
  4. After 1 second passed, you can target player or target again. Even with or without gm you can't target after cast.

EDIT: And this is done by all spells, what have simmiliar SpellVisual as holy nova.

EXTRA NOTES:

That has nothing to-do with unit_flags or unit_flags2. That bug exist on base sunwellcore too.

BRANCH(ES):

master

AC HASH/COMMIT:

https://github.com/azerothcore/azerothcore-wotlk/commit/71f98abc2c1653d9f91c34811bc3f9735fe1fba6

OPERATING SYSTEM:

Debian 10 / Windows Server 2k16

MODULES:

No modules. Clean rev

HOW TO TEST SOLO?

stiahnuť (1) stiahnuť

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/90840545-core-spells-spell-hitbox?utm_campaign=plugin&utm_content=tracker%2F40032087&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F40032087&utm_medium=issues&utm_source=github).
hguy23 commented 4 years ago

Anyone ? If it's true, then this is a PVP gamebreaking bug.

Algorak commented 4 years ago

On our old server it was also so that the Nova players and Npcs completely isolated. Is very useful for arena or Lk 25 hc when he goes berserk Lk cannot attack.

With us a dev fixed it but how I don't know unfortunately he is no longer active :(

FrancescoBorzi commented 4 years ago

@Algorak it would be nice if you could share the fixes with the community :)

ChrisCGalbraith commented 2 years ago

Have tested and can confirm it is true for holy nova as of: e60b953a7a8e9a7db37c3f6b1028c8cf6f75f7dd

After holy nova has hit the mob it becomes untargetable for approx 0.5 seconds.