search

azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.38k stars 2.55k forks source link

enable 'Quests.EnableQuestTracker' option,game delay.. #4005

Open mpfans opened 3 years ago

mpfans commented 3 years ago

chang worldserver.conf 'Quests.EnableQuestTracker' to 1 When there are about 800 players logging in the game, the game will have a great delay! It's not network delay....

AzerothCore revision : 4cb0c9f+ 2020-12-10 05:57:54 +0000 (master branch) OS:ubuntu 18.04 Module:mod-anticheat

mpfans commented 3 years ago

After 2 hours of enable , the quest_tracker table has only 2326 lines of data.then casting, talking to NPC, etc，no matter what you do in the game, there is a great delay. It's not network delay...

Kitzunu commented 3 years ago

cc @FrancescoBorzi @Helias

FrancescoBorzi commented 3 years ago

cc @FrancescoBorzi @Helias

I've implemented this feature myself several years ago at TrinityCore, it's been a while I haven't used it so I can't tell much right now. It would be nice to have a local reproduction of the issue.

BTW this is the (old) web tool to view the data in the table: https://github.com/TrinityCore/TC-Quest-Tracker

mpfans commented 3 years ago

cc @FrancescoBorzi @Helias

I've implemented this feature myself several years ago at TrinityCore, it's been a while I haven't used it so I can't tell much right now. It would be nice to have a local reproduction of the issue.

BTW this is the (old) web tool to view the data in the table: https://github.com/TrinityCore/TC-Quest-Tracker

Now it is not a tool to view the data in the table, but when the table is written, the game will be delayed

There may not be a server to replicate at this time, because I have a lot of players. There is no delay when there are only a few players

When 800 players are online, there is a delay. After 2 hours, there are only 2000 + rows in this table

Yehonal commented 3 years ago

Considering the code related to the Quest Tracker system, I cannot spot anything that can generate a lag since the INSERT/UPDATE queries are thrown asynchronously

https://github.com/azerothcore/azerothcore-wotlk/pull/1233/files

FrancescoBorzi commented 3 years ago

The issue might be that we directly run a query each time a quest is completed/abandoned/etc... so with many players online this can lead to performance issues.

Winfidonarleyan commented 3 years ago

I think I know what can be done

FrancescoBorzi commented 3 years ago

go @Winfidonarleyan :)

Winfidonarleyan commented 3 years ago

I'm starting work, after base test I create PR https://github.com/WarheadCore/WarheadCore/pull/182

Winfidonarleyan commented 3 years ago

Can retest this? @mpfans

mpfans commented 2 years ago

Can retest this? @mpfans

enable 'Quests.EnableQuestTracker' option?

Winfidonarleyan commented 2 years ago

Can retest this? @mpfans

enable 'Quests.EnableQuestTracker' option?

Yes, now no need

FrancescoBorzi commented 2 years ago

@mpfans @Winfidonarleyan status?

mpfans commented 2 years ago

@mpfans @Winfidonarleyan status?

I'll test it on next maintenance day

mpfans commented 2 years ago

There is no delay now

Winfidonarleyan commented 2 years ago

There is no delay now

Good

mpfans commented 2 years ago

In the previous test, there were not many player to do the quest. Now event 24 is turned on, resulting in delay! https://github.com/azerothcore/azerothcore-wotlk/issues/8754

mpfans commented 2 years ago

@Winfidonarleyan

Winfidonarleyan commented 2 years ago

Okay, need rework pet querys

Nyeriah commented 2 years ago

Still a problem? Pets fixed?

Winfidonarleyan commented 2 years ago

@mpfans

mpfans commented 2 years ago

need test....

FrancescoBorzi commented 2 years ago

@mpfans is this still valid? if not, let's close it

heyitsbench commented 1 year ago

@mpfans?

mpfans commented 1 year ago

no

mpfans commented 1 year ago

still delayed