[Spell] Judgement of Light/Wisdom PROC

[mnclaras]

CURRENT BEHAVIOUR:

Paladin Judgement of Light and Judgement of Wisdom spells should work with ppm rate, which is 15 currently (spell_proc_event table).

Now, the core have it hardcoded to proc up to 1 time every 4 seconds, which is not the same as PPM, limitating the proc to a maximum of 15 times per minute.

Implementation can be shown here: https://github.com/azerothcore/azerothcore-wotlk/blob/master/src/server/game/Entities/Unit/Unit.cpp#L7226 Where you can view the cooldown applied, instead of working with ppm properly: victim->AddSpellCooldown(20267, 0, 4 * IN_MILLISECONDS);

Also, I think the procs of this effect is not good either. Actually, the proc flags used are: 1048576, which is PROC_FLAG_TAKEN_ANY_DAMAGE (Any damage taken) I think it's bad, since it shouldn't proc with Periodic Damage.

EXPECTED BLIZZLIKE BEHAVIOUR:

Those skills should not have a cooldown of 4 seconds. They should proc based on ppm formula (probability). Proofs: In terms of what happened in Retail, you can see here a log of procs applied to a rogue in raid from this aura (taken from a raid in 2010 ~ Retail): http://www.worldoflogs.com/reports/0w1utsdyg1suwv3a/xe/?s=6425&e=7362&x=healSpell+%3D+%22Judgement+of+Light%22%0D%0AAND+targetName+%3D+%22Jumii%22

It should also proc with periodic damage spells, such as Consecration.

STEPS TO REPRODUCE THE PROBLEM:

1. Create a Paladin and level up to 80.
2. Cast any Judgement to a dummy, for example, and keep using skills (even Consecration, which is periodic damage).
3. You can see that it only procs one time per 4 seconds. Also, if you don't autoattack and only use Consecration, the proc will not heal/restore mana.

AC/HASH COMMIT

90526df

--- Want to back this issue? **[Post a bounty on it!](https://app.bountysource.com/issues/95766412-spell-judgement-of-light-wisdom-proc?utm_campaign=plugin&utm_content=tracker%2F40032087&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://app.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F40032087&utm_medium=issues&utm_source=github).

[Kitzunu]

@Yehonal

[avarishd]

https://classic.warcraftlogs.com/reports/mMVfrGpwxkZP3ht6#fight=40&type=healing&source=15&ability=20267&options=2&start=8448445&end=8509082&view=events

https://classic.warcraftlogs.com/reports/mMVfrGpwxkZP3ht6#fight=40&type=resources&start=8448445&end=8509082&spell=100&ability=20268&source=15&pins=2%24Off%24%23244F4B%24expression%24ability.name%20%3D%20%22Judgement%20of%20Wisdom%22&view=events

ppm varies a lot from class to class.