azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.52k stars 2.61k forks source link

Mistress Nagmara in BRD has an error in a saying #4257

Open Zoidwaffle opened 3 years ago

Zoidwaffle commented 3 years ago
CURRENT BEHAVIOUR:

As a part of the banter happening in the Blackrock Depths bar, Mistress Nagmara (the succubus), is saying a few things in response to the dwarf NPC's.

One thing she is saying is: Yes $gsir:madam;.

Screenshot from 2021-01-10 20-54-13

EXPECTED BLIZZLIKE BEHAVIOUR:

I would expect her to respond to the various NPC's and reply with a "Yes sir" to males and "Yes madam" to females.

STEPS TO REPRODUCE THE PROBLEM:
  1. .tele brd
  2. .go creature id 9500
  3. Stay a few minutes and wait for her to trigger the different sayings.
EXTRA NOTES:

I tried to see if I could figure this one out myself, but I don't understand how it's called - seems like Miss Nagmara should target different dwarfs to respond to their requests.

select * from creature_text where CreatureID=9500;
# ... and it's also referenced here...
select * from broadcast_text where ID>4978 and ID<4984;

but shouldn't there be some smart AI or similar as well triggering these? (I was unable to find that).

AC HASH/COMMIT:

37cb9f

OPERATING SYSTEM:

Debian 10

MODULES:

mod-account-achievements mod-ah-bot mod-arac mod-autobalance mod-congrats-on-level mod-morph-all-players mod-morphsummon mod-npc-buffer mod-transmog mod-weapon-visual

OTHER CUSTOMIZATIONS:
--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/95955140-mistress-nagmara-in-brd-has-an-error-in-a-saying?utm_campaign=plugin&utm_content=tracker%2F40032087&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F40032087&utm_medium=issues&utm_source=github).
Kitzunu commented 3 years ago

Weird. I can confirm this and it is due to wrong targettype in Smart_Script. but using anything but SMART_TARGET_SELF will make her not say anything.

SMART_TARGET_ACTION_INVOKER should fix it, but when I tried it she just stopped talking D:


SELECT * FROM smart_scripts WHERE entryorguid IN (9500,950000);