azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.6k stars 2.64k forks source link

"Chest of The Seven" from Blackrock Depths should spawn in a different position #4293

Closed Zoidwaffle closed 3 years ago

Zoidwaffle commented 3 years ago
CURRENT BEHAVIOUR:

Currently the chest spawns halfway over a ledge and in the middle of the room.

old_chest

EXPECTED BLIZZLIKE BEHAVIOUR:

The chest should spawn next to the door - this is from a video on YouTube

and for your convenience, I took a screenshot:

screenshot_youtube

STEPS TO REPRODUCE THE PROBLEM:
  1. .tele brd
  2. .go c id 9039
  3. As a GM you can see the chest not being by the door.
EXTRA NOTES:

I tried to fix this - if you apply this query:

-- "Chest of The Seven" from Blackrock Depths should spawn in a different position

UPDATE gameobject SET position_x="1265.55", position_y="-284.421", position_z="-78.2193", orientation="0.786698", rotation2="-0.383284", rotation3="-0.923631" WHERE guid=67872;

Then it will look like this:

new_chest

And I think it looks pretty close to what it should.

AC HASH/COMMIT:

37cb9f524218

OPERATING SYSTEM:

Debian 10

MODULES:

mod-account-achievements mod-ah-bot mod-arac mod-autobalance mod-congrats-on-level mod-morph-all-players mod-morphsummon mod-npc-buffer mod-transmog mod-weapon-visual

OTHER CUSTOMIZATIONS:
Voxstrasza commented 3 years ago

make a PR homie

Zoidwaffle commented 3 years ago

OK, so I tried to make a PR - I can see I don't have the part with:

DROP PROCEDURE IF EXISTS `updateDb`;
etc.

that can be seen in the ./data/sql/updates/db_world/ folder files, but should I add that as well?

Kitzunu commented 3 years ago

that should not exist, it is added by a bot when merged

Kitzunu commented 3 years ago

You have done correctly apart from my remarks in the PR

Zoidwaffle commented 3 years ago

Thanks, I should have fixed it now :+1:

BarbzYHOOL commented 3 years ago

Nice work!

btw to make a PR there is a lengthy guide on the wiki