search

azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.43k stars 2.58k forks source link

Quest items lootable by multiple party members. #4415

Closed 55Honey closed 3 years ago

55Honey commented 3 years ago

CURRENT BEHAVIOUR:

When looted in perfect sync (Interact with target activated via keybroadcasting), quest items which should drop only for one toon, can be looted with 2-5 toons. Without perfect sync, only one toon gets the reward. Tested on Pygmy Surf Crawler and Makrura Spellhide for the quest "A Solvent Spirit".

EXPECTED BLIZZLIKE BEHAVIOUR:

Only one quest item per corpse should be obtaiable for these kind of collection quests. Not one per toon.

STEPS TO REPRODUCE THE PROBLEM:

To reproduce it one would need an external program, e.g. Hotkeynet. Then have it send a key to all windows in perfect sync to make them all loot an once.

EXTRA NOTES:

Does not affect normal solo play or not even normal party play.

AC HASH/COMMIT:

https://github.com/chromiecraft/azerothcore-wotlk/commit/b905ce8c354b7cfac899ac3ab67209d2995b4de2

OPERATING SYSTEM:

OS: Ubintu 20.04

MODULES:

Chromiecraft server

OTHER CUSTOMIZATIONS:

Chromiecraft server

Kitzunu commented 3 years ago

I remember seeing the fix for this on TC yesterday... Now I can't find it xd

Kitzunu commented 3 years ago

https://github.com/TrinityCore/TrinityCore/commit/586c00fe2e226da99968ebe763d3226c6134658c

FrancescoBorzi commented 3 years ago

TrinityCore/TrinityCore@586c00f

thanks @Kitzunu . It seems simple, can you please provide a PR?

Kitzunu commented 3 years ago

Already working on it :D

Zoidwaffle commented 3 years ago

I believe I can confirm the issue - I have seen some loot behavior where items that would usually only drop once, appear to be looted by multiple gnomes (but not all) if interacting as a group. I cannot reproduce it reliably though... I multibox 5 characters at once.

@Kitzunu if you make a fix, I can apply it and try to see if I can trigger the issue.

Kitzunu commented 3 years ago

https://github.com/azerothcore/azerothcore-wotlk/pull/4420 @Zoidwaffle