azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.42k stars 2.57k forks source link

Mail visual bug #4494

Closed The-GhostRider closed 3 years ago

The-GhostRider commented 3 years ago

Originally reported https://github.com/chromiecraft/chromiecraft/issues/46

SMALL DESCRIPTION:

Items in mail do not display enchants

EXPECTED BLIZZLIKE BEHAVIOUR:

Item should display enchant

CURRENT BEHAVIOUR:

When displayed in inbox item does not display enchant. When taken out of mail item does have enchant displayed.

STEPS TO REPRODUCE THE PROBLEM:
  1. Enchant an item
  2. Sent to alt
  3. View before and after taking item out of mail.
AC HASH/COMMIT:

https://github.com/chromiecraft/azerothcore-wotlk/commit/b905ce8c354b7cfac899ac3ab67209d2995b4de2

OPERATING SYSTEM:

Ubuntu 20.04

MODULES:
OTHER CUSTOMIZATIONS:

None.

SERVER:

ChromieCraft

55Honey commented 3 years ago

As of today it is shown in retail shadowlands as well as classic: https://cdn.discordapp.com/attachments/354347338191339536/808065387446272000/unknown.png https://cdn.discordapp.com/attachments/354347338191339536/808069582631206972/unknown.png

The-GhostRider commented 3 years ago

I made the update today, morning..

https://user-images.githubusercontent.com/1884642/107156942-205f2e00-6979-11eb-8e2a-f92ac2bc1e2e.mp4

Kitzunu commented 3 years ago

This works on TC

FrancescoBorzi commented 3 years ago

@Kitzunu if you saw where the code is, we can find the PR fixing it with annotatate

Kitzunu commented 3 years ago

Probably this https://github.com/TrinityCore/TrinityCore/blob/06c1f728baca8e584fee8a10cb9e793abc5475bf/src/server/game/Server/Packets/MailPackets.cpp#L24-L44 https://github.com/TrinityCore/TrinityCore/blob/06c1f728baca8e584fee8a10cb9e793abc5475bf/src/server/game/Server/Packets/MailPackets.h#L31-L54

FrancescoBorzi commented 3 years ago

should be fixed by: https://github.com/azerothcore/azerothcore-wotlk/pull/4872

feel free to reopen if that's not the case