azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.51k stars 2.61k forks source link

No Mining Nodes in Roland's Doom (Duskwood) #4694

Closed ghost closed 3 years ago

ghost commented 3 years ago

No Mining Nodes inside Roland's Doom (Duskwood) 4 nodes outside.

WoWScrnShot_030321_011756

CURRENT BEHAVIOUR:

There are no mining nodes inside the mine called Roland's Doom in Duskwood.

EXPECTED BLIZZLIKE BEHAVIOUR:

There should be at least a couple mining nodes inside Roland's Doom. You can see some here in this video.

https://www.youtube.com/watch?v=-I-m9yqiYCQ

Maybe we should look at TrinityCore's nodes for all herbs/mines? There are many funky places for nodes such as;

1) Durotar near Sen'jin village (40 nodes in a small area). 2) Teldrassil (very few herbs on the entire zone). 3) Roguefeather Den in Thousand Needles (40+ iron nodes in a single cave).

STEPS TO REPRODUCE THE PROBLEM:
  1. Learn Find Minerals
  2. Go to Roland's Doom
  3. Look for mining nodes
EXTRA NOTES:
AC HASH/COMMIT:
OPERATING SYSTEM:
MODULES:
OTHER CUSTOMIZATIONS:
Zoidwaffle commented 3 years ago

I haven't checked TC for these nodes, but for other zones they are exactly the same as AC. Which makes them both wrong (at least in some cases).

I'm currently rewriting all the nodes for Bloodmyst Isle. It had a whopping 8 herbs, 3 mineral spawns and 0 treasures for an entire zone.

It's super boring to rewrite this stuff, but perhaps I could look into Duskwood as one of the next areas.

T1ti commented 3 years ago

For vanilla content, remember to check vmangos, they worked on that a lot more than TC.

vmangos does have veins in that cave image

Zoidwaffle commented 3 years ago

I looked a bit into this.

The mineral spawns definitely got some love already - there are 560 potential spawns and 112 pools... that are then combined into a master pool with 20 spawns.

I increased the amount of spawns - and found 2 mineral veins inside the mine.

So I don't think this is wrong as such - some tweaking might be fine, like:

UPDATE `pool_template` SET `max_limit`=30 WHERE `entry`=2009;

and to be fancy, make a "pool_pool" segment for the mine outside the rest of the zone, with perhaps 4 spawns (I didn't check how many spawn locations the mine have).

Zoidwaffle commented 3 years ago

OK, I'm preparing a PR with a suggestion for a solution.... Hopefully I get time to finish it this evening :)

Edit: So pretty much as I wrote above - made a PR with a possible solution.

Zoidwaffle commented 3 years ago

@JamesGent : I can have a look at other zones. If you report some issues with places that seem very wrong, I might prioritize those.

I have taken notes of Teldrassil and Thousand Needles you mentioned above :+1: