search

azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.12k stars 2.45k forks source link

Specific Drops and Zone Drops behaving like World Drops #4987

Open The-GhostRider opened 3 years ago

The-GhostRider commented 3 years ago

Originally reported https://github.com/chromiecraft/chromiecraft/issues/286

FACTION
CONTENT PHASE:
CURRENT BEHAVIOUR:

Items that should be very specific Zone Drops and Drops from specific NPCS are in World Drop Loot Tables, also know as: "reference_loot_template.sql" in the database.

Some examples that I've gathered are [Humbert's Helm] (Dropped off Undead mobs in Duskwood // Should be dropping from Dun'Garok Riflemen in Dun Garok) [Blackrock Champion's Axe] (Dropped off undead mobs in Duskwood // Should be dropping from Blackrock Champion in Redridge)

Other Items that I haven't personally encountered myself but are behaving like World Drops right now and should not: [Robes of the Shadowcaster] [Nightwalker Armor] [Cloak of Rot]

And so many many more... This have to be looked into in-depth.

EXPECTED BLIZZLIKE BEHAVIOUR:

Zone Drops and Specific Drops from a Specific mob should be dropping from said Zones/Drops respectively.

STEPS TO REPRODUCE THE PROBLEM:
  1. play the game
  2. get drops that don't belong to the area/mob
EXTRA NOTES:
AC HASH/COMMIT:

https://github.com/chromiecraft/azerothcore-wotlk/commit/8bacb39d53349f63066e84bcddb5a7f9300acb0d

OPERATING SYSTEM:

Ubuntu 20.04

MODULES:
OTHER CUSTOMIZATIONS:

None.

SERVER:

ChromieCraft

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/97349808-specific-drops-and-zone-drops-behaving-like-world-drops?utm_campaign=plugin&utm_content=tracker%2F40032087&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F40032087&utm_medium=issues&utm_source=github).
T1ti commented 3 years ago

Kinda related to https://github.com/azerothcore/azerothcore-wotlk/issues/4699

The-GhostRider commented 3 years ago

@Zoidwaffle Can you do this Fix pls? I trust of your judgment about drop rate. (And to avoid misunderstanding, and everything you do of course).😉👍

[EDIT] I have already verify this bug, and it is valid..

FrancescoBorzi commented 3 years ago

@Zoidwaffle are you still planning to work on this?

T1ti commented 3 years ago

how is that fixed ? was there any commit that fixed it or did you give up ?

The-GhostRider commented 3 years ago

image

T1ti commented 3 years ago

yeah but that's only 1 case .. ? you posted a few as examples and there are hundreds of area/zone/map specific drops

The-GhostRider commented 3 years ago

ah ok, my bad, i didn't notice..

The-GhostRider commented 3 years ago

btw, I haven't "Posted" this report, i just only made COPY and PASTE form CC

sudlud commented 3 days ago

Also how does this relate to the recent world drop / loot PR

Edit: @Gultask How does this relate to #18796

Gultask commented 3 days ago

There are some fixes but I can't say it's perfect. I went around fixing some, though.

I don't think we have any missing items, but it could be worth checking. I was using the addon ALLTHETHINGS to find these unique items and checking the DB. From what I recall the unique drops were correctly assigned to its mob, but then was also located randomly in a reference or two.