[WOTLK Dungeons] CLS System and General Tests

Knindzagxg commented 3 years ago

Tested Dungeons:

[X] The Nexus
[X] The Oculus
[X] Utgarde Keep
[X] Utgarde Pinnacle
[X] Halls of Stone
[X] Halls of Lighting
[X] Gundrak
[X] Drak'Tharon
[X] Azjol Nerub
[X] Ahn'kanet Old Kingdon
[X] Violet Hold
[X] Culling of Stratholme

Damage Tests Performed:

With Pre-Raid Rare Gear equiped (200ish iLvl).
[X] No issues found with damage on 'trash' mobs an or Boss fights.
[X] No problems so far, when it comes to damage. Will confirm first one (Above) once all are tested.
Changed required: Nothing towards Damage. Check bellow and in comments for other issues.

Issues Found:

Summoned creatures during combat will not attack unless player move. It appears every time on summon / spawn event from Boss or others NPC's.
Svala Sorrowgrave should come down faster once all Ritual adds are dead (Ritual of the Sword)
'Gauntlet' inside Halls of Lighting need some updates. Once you enter room and start event, there should be maximum 2 adds that will engage. Once i tried, on very first part i got 3 from each side (Total 6) which makes gauntlet deadly. 3 happening is super super rare, and it happens only if 1 is activated from X side. More then 95% times players should fight 4 total adds during X 'part' of the room.
Attack animation issue -> Pretty much this will happen everywhere if you run around NPC. You will see damage taken in numbers, but wont see actual animation of attack, unless it's a cast / spell.
It will happen more then 70% of time, unless something else happens and knock your character away.
Example bellow. https://www.youtube.com/watch?v=RVRqda5QgVA

Target Branch:

[X] Master

Operating System:

Linux (Debian 10)

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/97481758-wotlk-dungeons-cls-system-and-general-tests?utm_campaign=plugin&utm_content=tracker%2F40032087&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F40032087&utm_medium=issues&utm_source=github).

T1ti commented 3 years ago

Summoned creatures during combat will not attack unless player move. It appears every time on summon / spawn event from Boss or others NPC's.

I read something about that in very old issues, it's a global issue with how creatures work, they only see players when players move.

T1ti commented 3 years ago

See : https://github.com/azerothcore/azerothcore-wotlk/issues/524 https://github.com/azerothcore/azerothcore-wotlk/pull/2643 more talk about it here.

I think there should be a rewrite of this system with a fat bounty

Knindzagxg commented 3 years ago

Yeah, it's known issue. I'm just confirming while testing.

CLS working pretty good so far tho, i like it xP

Si1ker commented 3 years ago

Same as said in discord, but just to keep note on it, svala has no error.

Videos from 2008 confirms she always keep the full casting of "Ritual of the sword" no matter if there are banshees alive or not.

https://www.youtube.com/watch?v=GpPAvgaqGlk 20 oct 2008 [15:36] https://www.youtube.com/watch?v=tSjkLlgvew0 23 nov 2008 [15:36] https://www.youtube.com/watch?v=gfnGFbAC4dI 26 nov 2008

Knindzagxg commented 3 years ago

As you can see on my picture, Ritual was over 10-15 sec and for some reason she was up in the air still. Also, forgot to mention -> There was no fallin' sword animation, but will retest again to be sure.

Knindzagxg commented 3 years ago

Culling of Stratholme - Chromie have issue with double text options.
Meathook and Salramm should start walking / roam once spawned.
Also, there should be "flag" for them on map as we have for trash mob waves.

@FrancescoBorzi -> Beside those minor issues, WOTLK Dungeons have pretty good damage now. Won't have tank and spank fights anymore and people will have to consider CC's and pulling smaller packs. Will check TBC / Classic Dungeons next and then Raids.

FrancescoBorzi commented 3 years ago

excellent news @Knindzagxg good job!

Ragelezz commented 2 years ago

So what are the issues in this ? As i can read, some are fixed, some are general.

Knindzagxg commented 2 years ago

Issues are described with pictures. If anything is fixed, it should be mentioned towards this, so we can close it.

azerothcore / azerothcore-wotlk