azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.64k stars 2.65k forks source link

Dragonlings Attack Non-PVP-Flagged Opposite Faction Players #5590

Open Azcobu opened 3 years ago

Azcobu commented 3 years ago

WHAT CLIENT DO YOU PLAY ON?

FACTION
CONTENT PHASE:
CURRENT BEHAVIOUR:

Original report: https://github.com/chromiecraft/chromiecraft/issues/505

I was doing a Random Dungeon with 4 Alliance and 1 Horde Player. When I used the Mechanical Dragonling Trinket, it attacked the enemies from the dungeon. But when the Mobs died the Dragonling attacked the Horde Player in my group. The Person had no PvP enabled. And I had no control of the Dragonling, even removing the Trinket did not make him disappear.

Tester's notes - tested this with four kinds of mechanical guardian pets:

  1. Mechanical Dragonling - https://wotlkdb.com/?item=4396
  2. Mithril Mechanical Dragonling - https://wotlkdb.com/?item=10576
  3. Arcanite Dragonling - https://wotlkdb.com/?item=16022
  4. Gnomish Battle Chicken - https://wotlkdb.com/?item=10725

The Battle Chicken worked fine and did not aggro opposite faction players at all.

The three dragonlings wouldn't aggro on an opposite faction player by themselves. But if an NPC mob attacks or is attacked, they will attack the NPC and then aggro on the opposite faction player.

No NPCs, so not a problem: WoWScrnShot_050221_155404

NPCs are dead, so now it's death to the Alliance. Note here the dragonling is actually attacking the Ally in preference to the nearby NPC. WoWScrnShot_050221_162408

EXPECTED BLIZZLIKE BEHAVIOUR:

It should only attack Enemies/Players that are hostile to you.

STEPS TO REPRODUCE THE PROBLEM:
  1. Equip one of the 3 dragonling trinkets.
  2. Get into combat with an NPC with an opposite faction player nearby.
  3. Activate dragonling.
  4. It will attack the NPC, and then the opposite faction player.
EXTRA NOTES:
AC HASH/COMMIT:

https://github.com/chromiecraft/azerothcore-wotlk/commit/91081f4ad8fed98d7bdc9c0ae13d05c86032df9f

OPERATING SYSTEM:

Ubuntu 20.04

MODULES:
OTHER CUSTOMIZATIONS:

None.

SERVER:

ChromieCraft

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/98247145-dragonlings-attack-non-pvp-flagged-opposite-faction-players?utm_campaign=plugin&utm_content=tracker%2F40032087&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F40032087&utm_medium=issues&utm_source=github).
Annamaria-CC commented 3 years ago

Also related: The dragonling does not attack same faction during a duel.

Nyeriah commented 5 months ago

Please test after https://github.com/azerothcore/azerothcore-wotlk/pull/19039