azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.58k stars 2.64k forks source link

The Green Tower Shield - Proc Does Not Work #5649

Closed Azcobu closed 1 year ago

Azcobu commented 3 years ago

WHAT CLIENT DO YOU PLAY ON?

FACTION
CONTENT PHASE:
CURRENT BEHAVIOUR:

Original report: https://github.com/chromiecraft/chromiecraft/issues/531

The Equip on the lvl 36 item The Green Tower does not proc. https://wowgaming.altervista.org/aowow/?item=1204

Tester's notes - The proc is only a 1% rate anyway, but tried this with an 80 warrior wearing the shield vs a fast-hitting lvl 20 druid cat, and let the cat melee the warr for about 10 mins, delivering about 600 melee attacks. No procs were seen before the warr died, so it does seem pretty likely the proc is not working.

WoWScrnShot_050521_231513

EXPECTED BLIZZLIKE BEHAVIOUR:

" When struck in combat has a 1% chance of raising a thorny shield that inflicts 3 Nature damage to attackers when hit and increases Nature resistance by 50 for 30 sec."

The spell it should cast is https://wowgaming.altervista.org/aowow/?spell=18097

STEPS TO REPRODUCE THE PROBLEM:
  1. Have a high level character with the shield duel a low level character (so they don't do much damage)
  2. Gather a few hundred melee strikes.
EXTRA NOTES:

https://wowgaming.altervista.org/aowow/?item=1204

AC HASH/COMMIT:

https://github.com/chromiecraft/azerothcore-wotlk/commit/91081f4ad8fed98d7bdc9c0ae13d05c86032df9f

OPERATING SYSTEM:

Ubuntu 20.04

MODULES:
OTHER CUSTOMIZATIONS:

None.

SERVER:

ChromieCraft

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/98292739-the-green-tower-shield-proc-does-not-work?utm_campaign=plugin&utm_content=tracker%2F40032087&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F40032087&utm_medium=issues&utm_source=github).
Maxproz commented 3 years ago

https://github.com/azerothcore/azerothcore-wotlk/pull/5682

Tony931023 commented 1 year ago

@Nyeriah Can it be closed now?, solved in https://github.com/azerothcore/azerothcore-wotlk/commit/dfa5da00b1253a944884d86796577dddcc799255