azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.45k stars 2.59k forks source link

Wrong Weapon in the ActionBar #5770

Open ghost opened 3 years ago

ghost commented 3 years ago

WHAT CLIENT DO YOU PLAY ON?

FACTION
CONTENT PHASE:
CURRENT BEHAVIOUR:

My equipped weapon is Notched Shortsword of Stamina. I have Notched Shortsword of Strength in my Inventory. I already have a shorcut for my equipped weapon on the "Right Actionbar 2" (Notched Shortsword of Stamina). If I try to create a shortcut for the Inventory weapon (Notched Shortsword of Strength) on a free slot of any Actionbar through the drag & drop feature, another shortcut for the Equipped weapon is created instead.

I posted the screenshots in the Notes section

EXPECTED BLIZZLIKE BEHAVIOUR:

Dragging the Inventory weapon on a slot of the Actionbar, a shortcut to that weapon should be created.

STEPS TO REPRODUCE THE PROBLEM:
  1. Have a Notched Shortsword of Stamina equipped
  2. Create a shorcut of the Equipped Weapon on the RightActionbar dragging the item on the slot with the mouse
  3. Have a Notched Shortsword of Strength in the inventory
  4. Try to create a shorcut of the Notched Shortsword of Strength on any Actionbar dragging the item on a free slot with the mouse
EXTRA NOTES:

Screenshots of the Bug: immagine immagine immagine

Shortcut Created after dragging the Notched Shortsword of Strength on the Actionbar:

immagine

AC HASH/COMMIT:

https://github.com/chromiecraft/azerothcore-wotlk/commit/91081f4ad8fed98d7bdc9c0ae13d05c86032df9f

OPERATING SYSTEM:

Ubuntu 20.04

MODULES:
OTHER CUSTOMIZATIONS:

None.

SERVER:

ChromieCraft

"Originally reported https://github.com/chromiecraft/chromiecraft/issues/552"

Confirmed and reproduced on a local AC server :

WoWScrnShot_051021_203339 WoWScrnShot_051021_203404 WoWScrnShot_051021_203918

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/98393275-wrong-weapon-in-the-actionbar?utm_campaign=plugin&utm_content=tracker%2F40032087&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F40032087&utm_medium=issues&utm_source=github).
gabryatfendor commented 6 months ago

The issue is probably wider: if you have two different notched shortsword, one equipped and one in the inventory, and you try to create a shortcut to the one in the inventory, a shortcut to the equipped one is created. Maybe this is related to the fact that the two weapons share the same item id? Indeed the same things happen with other "random enchant" items, like Dragon Finger. The table in the char DB that holds the item ID in the action bar stores only the item ID in the "action" column for reference