Warrior/Druid Charge Occasionally Clipping Through World

[Azcobu]

WHAT CLIENT DO YOU PLAY ON?

• [ ] enGB
• [x] enUS
• [ ] other (specify)

FACTION

• [x] Alliance
• [x] Horde

CONTENT PHASE:

• [ ] Generic
• [x] 1-19
• [ ] 20-29
• [ ] 30-39
• [ ] 40-49
• [ ] 50-59

CURRENT BEHAVIOUR:

Original report: https://github.com/chromiecraft/chromiecraft/issues/774

When I charged the Redridge Mystic on top of a hill in Redridge, I fell under the texture.

Tester's notes: The NPC is question has a GUID of 28327, and it is standing on a sharp little hill. The clipping issue is not common, but it can happen:

https://user-images.githubusercontent.com/81782124/120879921-01f6ff80-c606-11eb-8af0-28ab351022d6.mp4

EXPECTED BLIZZLIKE BEHAVIOUR:

It shouldn't happen.

SOURCE:

STEPS TO REPRODUCE THE PROBLEM:

1. .go c 28327
2. Charge the Redridge Mystic if he stands on the little hill like on the screenshot
3. Keep trying, it took ages to verify.

EXTRA NOTES:

AC HASH/COMMIT:

https://github.com/chromiecraft/azerothcore-wotlk/commit/40cf7b46d221e562a20264316d660318af213690

OPERATING SYSTEM:

Ubuntu 20.04

MODULES:

• mod-ah-bot
• mod-cfbg
• mod-desertion-warnings
• mod-duel-reset
• mod-eluna-lua-engine
• mod-multi-client-check
• mod-pvp-titles
• mod-server-auto-shutdown
• lua-CarbonCopy
• lua-LevelUpReward
• lua-send-and-bind

OTHER CUSTOMIZATIONS:

None.

SERVER:

ChromieCraft

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/98988594-warrior-druid-charge-occasionally-clipping-through-world?utm_campaign=plugin&utm_content=tracker%2F40032087&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F40032087&utm_medium=issues&utm_source=github).

[ghost]

Test feedback

Right off the bat I can spot an issue. These images show the before and after charge so the player isn't facing the enemy and not close enough to it.

[ghost]

Been a while doing this and can't reproduce at all... I don't doubt this happening but how worth the effort is spending time on something that isn't reproduceable that easily. 🤔

[Azcobu]

Comment on the CC issue from @Invicta1986:

I can confirm this is happening both to me and my warrior friend as well, sadly I can not give more details at this point other than we have used Charge and randomly it has made us fall through terrain with instant respawn at graveyard as result.. we are both horde if that matters !

[ghost]

Recently my girlfriend has also been having issues with Charge. Sometimes, seemingly random, after using charge the character ends the charge facing backwards, instead of facing the mob. Have you also had this issue?

[Azcobu]

Not on my bear, but I don't actually play on Chromie much these days, so I'm probably not the best person to ask. Maybe try the warrior channel on CC Discord?

[syssneck]

Still happens from time to time, as I heard. I'm not sure, if this is a general thing or a problem with the maps in some places. Happened to me today on a warrior in Searing Gorge on CC.

If the position, that you charge to, is higher, than your current position, there is a good chance, that you will clip through the floor.

[bgcfb]

I think some time it related to big creature model,some big creature's foot is under the ground

[ntrna]

EDIT: bounty is no longer available except for IntelligentQuantum if he wants it. It's been a month & gold is only becoming less valuable on CC. I will pay 750g on ChromieCraft for a fix. I am not trying to be offensive, if I am lowballing you, let me know.

[Azcobu]

Also note a good spot for testing this is in the Wetlands just outside Menethil Harbor. .go c 10904 takes you to a murloc very close by. See the issue above for more details.

[IntelligentQuantum]

https://github.com/TrinityCore/TrinityCore/pull/24010

[ntrna]

The 750g is up for @IntelligentQuantum if he wants it. Otherwise, I'm cancelling my gold bounty, because no one has claimed it in a month, there is a boatload of gold on ChromieCraft, & I spent most of it.

[sschepens]

@ntrna I implemented the fix @IntelligentQuantum posted and I seem to not be clipping anymore, also we always end correctly facing the target.

It would be great to get some review

[sschepens]

Testing in Ring of Valor I find that whenever the target (and probably caster) are on elevators at ground level, charge fails with No Path Available.

This is actually a strictly specified case in the spell, but I don't know if this is Blizzlike mechanics, it certainly seems weird, since the target is actually on ground level.

If anyone can specify the correct mechanics, i can try and fix this, but it could prove difficult, what if someone charges exactly when elevator starts ascending?

[acidmanifesto]

Currently my pr fixes charge and druids charge however we need new vmaps as blinking goes thru game objects.

[Azcobu]

Note another spot to test this as listed in https://github.com/chromiecraft/chromiecraft/issues/2375 is the final boss's room in LBRS - .go c 45821 will port you to an NPC right in front of the area to charge across.

[anthonygauthier]

Another great spot to test this is with the mobs on the edge of Un'Goro (as mentionned in the duplicate) #1980. Happened to me twice in about 40 minutes and I literally never had the problem pop up before today.

[Shineslippers]

One more place. Warsong. .go xyz 939.394897 1482.591309 366.373840

[acidmanifesto]

https://github.com/azerothcore/azerothcore-wotlk/pull/8775

[Shineslippers]

Ragnaros. Any charge in this zone is leading to undeground.

[acidmanifesto]

https://github.com/azerothcore/azerothcore-wotlk/pull/8775 Warrior charges does work with that pr. The issues is we need to update game maps. Currently all undermeshing is fixed with that pr, but we are having unintended side effects with blink ignoring gameobjects which goes back to the gameobjects and maps

[heyitsbench]

Possibly related: https://github.com/azerothcore/azerothcore-wotlk/discussions/3971