azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.58k stars 2.63k forks source link

Midsummer fest double spawning NPC's #6469

Closed Stump876 closed 2 years ago

Stump876 commented 3 years ago

Chromiecraft report https://github.com/chromiecraft/chromiecraft/issues/928

WHAT CLIENT DO YOU PLAY ON?

FACTION
CONTENT PHASE:
CURRENT BEHAVIOUR:

There are a lot of NPC's double spawning for the fire festival event. Anyone can feel free to add to this as they encounter more. Additionally some humans are labeled as "Goblin Commoner" and have beer mugs and talk about gathering colored eggs. as well as goblins with human masks with beer mugs saying the same thing. I don't think these should be spawned at all. This is all kinds of incorrect. (second screenshot) image image

EXPECTED BLIZZLIKE BEHAVIOUR:

Should not be doubled up.

SOURCE:
STEPS TO REPRODUCE THE PROBLEM:
  1. Wild shore Area, Stranglethorn Vale: .go creature: 96711, 23791, 16412, 94603, 94550, 94555, 94551, 16433, 94553, 94552, 94786, 94781, 94694, 94653, 94656, 94693, 94489, 94518, 94654, 94711, 94710, 94655
  2. Booty Bay (these are general "Goblin commoner" with mugs and talking about gathering eggs, sometimes there are three: .go creature: 93646, 93762, 93763, 93652, 725, 93587, 93913, 724, 93764, 16433, 727, 93734, 93639, 726, 93610,
  3. Burning Steppes: .go creature: 245649, 248581
EXTRA NOTES:

Type here.

AC HASH/COMMIT:

https://github.com/chromiecraft/azerothcore-wotlk/commit/34da0cda5195dede48cb0406b23248330d6249cb

OPERATING SYSTEM:

Ubuntu 20.04

MODULES:
OTHER CUSTOMIZATIONS:

None.

SERVER:

ChromieCraft

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/99363467-midsummer-fest-double-spawning-npc-s?utm_campaign=plugin&utm_content=tracker%2F40032087&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F40032087&utm_medium=issues&utm_source=github).
Stump876 commented 3 years ago

Also https://github.com/chromiecraft/chromiecraft/issues/935 Ironforge: GUID 202860, 94663 GUID 202861, 94661 GUID 202859, 94662 GUID 202858, 94664

Stump876 commented 3 years ago

Also https://github.com/chromiecraft/chromiecraft/issues/936 and https://github.com/chromiecraft/chromiecraft/issues/937

Darnassus: GUID 94747, 94739

Arathi Highlands: GUID 94704, 94636 GUID 94556, 94637 GUID 94635, 94557 GUID 94634, 94605

Azcobu commented 3 years ago

Further instances:

Mulgore: reported in https://github.com/chromiecraft/chromiecraft/issues/940 GUID 248583, 245692 - also Mulgore is missing tents and braziers


Azuremyst Island: reported in https://github.com/chromiecraft/chromiecraft/issues/942 GUID 248584, 245645 - other midsummer festival NPCs are missing/not spawned


Bloodmyst Isle: reported in https://github.com/chromiecraft/chromiecraft/issues/943 GUID 245648, 248585 - missing tent and other npcs


Feralas - Feathermoon Stronghold: reported in https://github.com/chromiecraft/chromiecraft/issues/944 There is an additional set of Festival Decorations and NPC (GUID 248582) at the Forgotten Coast (46.6,44.2), but no fire. At the correct location east of Feathermoon Stronghold, some decorations are missing, but the fire is in place.


Silithus: reported in https://github.com/chromiecraft/chromiecraft/issues/945 GUID 94649, 94575 GUID 94697, 94738 GUID 86704, 86716 GUID 94580, 94700 GUID 94579, 94699


Stranglethorn Vale: reported in https://github.com/chromiecraft/chromiecraft/issues/948 By Ally FP: GUID 93610, 93639 - humans labelled as goblins GUID 93695, 93734 - ditto. Even humans are listed as Goblin Commoner which is another bug. There should only be 2 spawned. There is an issue with the goblin commoners spawned when theres no events going on, but now for each location 2 additional ones were spawned.

By Horde FP: GUID 93587, 92568 - humans labelled as goblins GUID 93913, 93764 - first one a human, second a goblin.


Tanaris, Gadgetzan: reported in https://github.com/chromiecraft/chromiecraft/issues/950 Many humans are labeled Goblin Commoner GUID 91761 (human), 91760 GUID 91759 (human) GUID 91753, 91764 GUID 91754, 91765 (all human) GUID 91762, 91755 (human) GUID 91756, 91763 (both human) GUID 91758, 91757 (both human)


Barrens, Ratchet: - reported in https://github.com/chromiecraft/chromiecraft/issues/957 GUID 91118, 91749(both human) GUID 91117 (human), 91707 GUID 91115, 91750 GUID 91116, 91751 (all 4 human) GUID 91704 GUID 91706, 91705 (all 3 human)


Burning Steppes: - reporting in https://github.com/chromiecraft/chromiecraft/issues/946 Two Flame wardens spawned, GUID 248581, 245649 - also missing NPCs

gurveleg commented 3 years ago

I checked Outland Midsummer locations on local AC so they can be fixed too when working on fixing the old world locations - or they'll be brought up next time when TBC is unlocked on Chromiecraft and Midsummer active:

Zangarmarsh: Alliance: Double Flame Warden GUID 245669, 248589, Missing other NPCs and Decorations

Nagrand: Alliance: Double Flame Warden GUID 245660, 248590, Missing other NPCs and Decorations

Terrokar Forrest: Alliance: Double Flame Warden GUID 245664, 248586, Missing other NPCs and Decorations

Shadowmoon Valley: Alliance: Double Flame Warden GUID 245662, 248588, Missing other NPCs and Decorations

Horde: Double Flame Warden GUID 245694, 248587, Missing other NPCs and Decorations

Blades Edge Mountains: Alliance: Double Flame Warden GUID 248591, 245646, Missing other NPCs

Horde: Double Flame Warden GUID 245682, 248592, Missing other NPCs

Netherstorm: Horde: Double Flame Warden GUID 245675, 248594, Missing other NPCs and Decorations

Alliance: Double Flame Warden GUID 245670, 248593, Missing other NPCs and Decorations

Shatratth: Many Human Goblin Commoners Aldor Inn: GUID 91801, 91794 Scryers Inn: GUID 91774 Aldor Bank: GUID 91768, 91769 Scryers Bank: GUID 91770 Horde Portals: GUID 91779 Alliance Portals: GUID 91776, 91777

AzerothCore rev. 3b58f5602928