azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.4k stars 2.55k forks source link

Timer On Rogue's Sap Pauses When Out of Sight of Target #7069

Closed Azcobu closed 3 years ago

Azcobu commented 3 years ago

What client do you play on?

frFR

Faction

Content Phase:

Current Behaviour

Original report: https://github.com/chromiecraft/chromiecraft/issues/1244

When you're in a dungeon and you sap a npc, you can run away from it to lose sight and when you come back, you can observe that the npc is still sapped and the timer runs again like it was paused.

You can see in chat the time : 18:08:35 when about to lose sight with 22s remaining on the sap WoWScrnShot_071921_180840 Then you see the time after a few killed mobs : 18:09:11, that's already 36s from first screen WoWScrnShot_071921_180917

Then when I come back the npc was still sapped and I guess the timer kept running again when I was in his sight.

https://user-images.githubusercontent.com/82708448/126192761-931b2c41-4922-45f7-ba4a-3d8610c6e020.mp4

Tester: confirmed. You have to go far enough away that you lose the target, but that appears to stop the timer completely. This seems to be a dungeon-only issue. I tested in open world, and the sap timer kept going even when the target was out of sight.

There are 4 ranks of Sap (rank 1 = spell ID 6770, rank 2 = 2070, rank 3 = 11297, rank 4 = 51724) and all four tested displayed this problem.

4.5 minutes sap in SM: WoWScrnShot_072221_212016

2.5 min sap, Maraudon: WoWScrnShot_072221_213557

Working fine in open world: WoWScrnShot_072221_214045

Expected Blizzlike Behaviour

Sap timer (25/35/45/60 secs depending on rank) should end normally either if you're in sight of the mob or not.

Source

No direct source, but this doesn't seem a controversial claim.

Steps to reproduce the problem

  1. Enter a dungeon as a rogue.
  2. Sap a npc.
  3. Run away from him, and check the remaining time on the debuff while losing sight.
  4. Take your time out of sight (more time than the remaining debuff obviously).
  5. Come back and observe the npc still sapped with the remaining timer running as soon as you enter his sight.

AC rev. hash/commit

https://github.com/chromiecraft/azerothcore-wotlk/commit/c7129fa0dd7b9951589599654fe83cdcd2a55d7a

Operating system

Ubuntu 20.04

Modules

Customizations

None

Server

ChromieCraft

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/100042991-timer-on-rogue-s-sap-pauses-when-out-of-sight-of-target?utm_campaign=plugin&utm_content=tracker%2F40032087&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F40032087&utm_medium=issues&utm_source=github).
UltraNix commented 3 years ago

it's the same in open world. It's just grids that are going deactivated when there is no player around. It's normal.

Azcobu commented 3 years ago

Closing as per above.