Inconsistent behavior between GM command levels

LightDestory commented 3 years ago

Current Behaviour

The commands:

".account create" and similar
".reset all" and sub-commands

These commands are both GM Level 4 (= Console privilegies) commands, a normal Level 3 GM can't use them, but there is a different behavior if a GM still tries to run these commands:

".account create" will outputs the GM account level if the GM is not level 4
".reset all ..." will output that not exists such commands (I checked the source code and this command is surely implemented)

This difference led me to open #7305

Expected Blizzlike Behaviour

Both commands should have the same output. Whatever you choice.

Source

No response

Steps to reproduce the problem

Run:

.account create
.reset all spells

Extra Notes

No response

AC rev. hash/commit

328184f

Operating system

Unix (Using the ChromieCraft test server)

Custom changes or Modules

No response

Kitzunu commented 3 years ago

If you try to use a command ypu have no perms for it will say it doesnt exist. If you try to use a command tjat you have partial access too. In this case ypu can use .account and not .account reset, it willl display the first argument

LightDestory commented 3 years ago

So, it is a wanted behavior? If yes, we can close this issue as it doesn't need any more arguments :)

Kitzunu commented 3 years ago

To me it is reasonable for it to be this way, but feel free to say if you disagree

Kitzunu commented 3 years ago

Also unrelated, I think a lot of our commands are set to the wrong level by default. I don't like it.

However, I also think that we should properly implement RBAC instead. I have started to implement it https://github.com/azerothcore/azerothcore-wotlk/pull/6839 but atm I have no time to figure out why it is crashing. I might look back into it in a couple of weeks

azerothcore / azerothcore-wotlk