Warrior "Sweeping Strikes" Ability - Secondary Target Damage Bugged

[Azcobu]

What client do you play on?

enUS

Faction

• [X] Alliance
• [X] Horde

Content Phase:

• [X] Generic
• [ ] 1-19
• [ ] 20-29
• [ ] 30-39
• [ ] 40-49
• [ ] 50-59

Current Behaviour

Original report: https://github.com/chromiecraft/chromiecraft/issues/1580

When the buff "Sweeping Strikes" is up on the warrior (Arms talent ability) the five attacks that strike an additional opponent deal different damage (always lower) than the main attack they copy. I found the same exact bug a couple years ago on another server named TrueWow and helped to fix it. It behave like the armor of the "additional nearby opponent" is further reducing the damage of the sweeping strike hit -which is not correct because the damage of the hit that will be "copied" is already reduced by the first opponent's armor.

Tester: confirmed. Tried this for a bit and the secondary target damage was always less than the primary, and always by the same percentage ratio. It looks like the secondary target's armour is being counted twice, as was the case for the similar issue involving the rogue Blade Flurry skill - see https://github.com/azerothcore/azerothcore-wotlk/issues/6900

Expected Blizzlike Behaviour

When the buff "Sweeping Strikes" is up on the warrior (Arms talent ability) the five copied attacks should be of the exact amount of damage of the original hit.

"It tries to copy your direct damage attacks to a secondary target, exactly like the rogue Blade Flurry talent, except SS is limited to only 5 attacks. ... Basically, SS will copy the instant damage of a skill but not the effect. SS + hamstring will do 50ish damage on both targets but only hamstring the primary target, for instance."

"Sweeping Strikes only duplicates the damage from your hits." - https://www.mmo-champion.com/threads/602307-Sweeping-Strikes-and-Mortal-Strike?p=5521686&viewfull=1#post5521686

Source

https://hilbert.wordpress.com/sweeping-strikes-guide (Classic, but mechanics are the same.) https://wowpedia.fandom.com/wiki/Sweeping_Strikes?oldid=2378895

Steps to reproduce the problem

1) Activate Sweeping Strikes with an Arms Warrior 2) Need two-three enemies to hit in order to make Sweeping Strikes hit a nearby opponent 3) Observe the difference in damage between the original hit and the sweeping strike hit copied.

Extra Notes

AC rev. hash/commit

https://github.com/chromiecraft/azerothcore-wotlk/commit/d20f315bd5370761f226460964ae506a97f372c0

Operating system

Ubuntu 20.04

Modules

• mod-ah-bot
• mod-cfbg
• mod-chromie-xp
• mod-desertion-warnings
• mod-duel-reset
• mod-eluna-lua-engine
• mod-ip-tracker
• mod-low-level-arena
• mod-multi-client-check
• mod-pvp-titles
• mod-pvpstats-announcer
• mod-queue-list-cache
• mod-server-auto-shutdown
• lua-carbon-copy
• lua-custom-corldboss
• lua-level-up-reward
• lua-recruit-a-friend
• lua-send-and-bind
• lua-temp-announcements
• lua-zonecheck

Customizations

None

Server

ChromieCraft

[laasker]

Damage is still really weird.. should i post here or open a new issue?

to explain, i tested in pvp with 2 warlocks with same resilience, armor, talents, etc and it kinda looks like that: if damage is more than 3500 then sweeping strikes deals more damage if damage is less than 3000~3500 then sweeping strikes deals same or less damage

Second target is getting hit by 7k, its possible to hit for 9~10k if if you manage to crit 7k+ on main target

all prints here: https://imgur.com/a/QZJP2Jb

[Azcobu]

Thanks for the update. I've confirmed variation in Sweeping Strikes damage, so will reopen this issue. Feel free to post any more info here rather than in a new ticket.

For my test, I spawned 2 x Unkillable Target Dummies, ID 1000, so totally identical NPCs. My understanding is that the Sweeping Strikes damage should be copied across to the second target, so should be identical, but that was not the case - the second strike varied quite a bit, and was sometimes even higher than the original, which definitely isn't correct:

Note here the primary target is taking less damage than the secondary:

Testing was on 94c0a3a72996.

[UltraNix]

@Azcobu My tests look okay (melee swings only)

[UltraNix]

Slam. One hit is different because of BloodFRenzy on primary target (and it's okay)

[UltraNix]

Heroic Strike (2 hits with Blood Frenzy):

For me everything works okay. @Azcobu Please confirm it.

[laasker]

Heroic Strike (2 hits with Blood Frenzy):

For me everything works okay. @Azcobu Please confirm it.

is there a scalling or something in sweeping strikes? the last screenshot of my post shows what im talking about, i crit a mortal strike for 5383 on one target and the secondary target/sweeping strikes target gets hit for 7034 with same armor, resilience, gear buffs etc

[UltraNix]

There is no scaling - simple transfer basic damage

[Azcobu]

If there's no scaling, is it other talents/procs/effects causing the damage difference?

I deleted and remade a warr to make sure no leftover talents were causing problems, added just enough talents to get Sweeping Strikes so no other talents would interfere, and had him attack some dummies (started using Hellfire Dummies ID 17578 as they don't fight back and mess up the log) and I'm still seeing variation in SS damage for both Slam and Heroic Strike:

Also saw instances where ordinary white auto-attacks weren't consuming stacks of Sweeping Strikes at all. No idea why I'm getting different results, will go and rebuild everything and see if that helps.

[UltraNix]

I don't know. You can alsotype .unaura on all targets and war and then activate SS and see what happens.

[Azcobu]

.unaura seems to need a spell ID to remove, so I used .debug setaurastate = 0 which I hope does the same thing. I'm still getting uneven results for Slam/Heroic Strike even after using that on the two targets + warr.

[UltraNix]

@Azcobu unaura all Show me these results.

[Azcobu]

This is using .unaura all, I've also checked warr's talents and there aren't any debuffs being applied in combat that I'm aware of, like armour reduction or whatever.

[UltraNix]

Still can't reproduce on my local :/

[Azcobu]

If you can't reproduce it then I'll close the issue, it's more likely to be me missing something.

[UltraNix]

@Azcobu But the original issue on CC was reported by someone else.