azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.63k stars 2.64k forks source link

Pit of Saron - Trash mobs problem #862

Closed Knindzagxg closed 3 years ago

Knindzagxg commented 6 years ago

Description: Mobs after second boss, that come for event to 'block' free passage, drop under ground every single time.

Current behaviour: For some reason, they drop under texture, and keep agrro players from there.

Expected behaviour: They should stay at the top, so they can attack and kill them. Unable due LoS.

Steps to reproduce the problem: Not sure.

Hash: 7696bd3

Operating system: Linux, Debian 9

Modules: Premium, Congrats on level.

Other Customizations: No.

Pic: https://i.imgur.com/fD27U9Z.jpg

Motorheadx commented 6 years ago

Steps to reproduce the problem: just enter the battle from far away and they fall when they go down.The problem is old it is still in the original Sunwellcore

ZeegCL commented 6 years ago

Can confirm. That said, you still can walk down the ramp and get them from bellow the road

PD: for clarity, these ones pit-of-saron-dungeon-map

sucofog commented 6 years ago

Confirmed

Motorheadx commented 6 years ago

I think this is some global problem

Viste commented 6 years ago

Confirmed and plus to @Motorheadx for example wintergrasp canons some times fall to texture and mobs on WG to

talamortis commented 6 years ago

This didnt happen before the maps,mmaps and vmaps got reworked

Motorheadx commented 6 years ago

it's in the original sunwellcore there is a problem

BarbzYHOOL commented 6 years ago

And original sunwellcore has no mmaps reworked

Motorheadx commented 6 years ago

Yes, this problem is not due to mmaps rework, this something else=)

I think that the problem is somewhere in MoveSplineInit or somewhere incorrectly calculated Z coordinate

sucofog commented 6 years ago

The problem is not on the maps/vmaps/mmaps rework, not related

Viste commented 6 years ago

@talamortis its sunwell global problem and @Motorheadx right i agree it somewhere in Movespline

sucofog commented 6 years ago

Yes, the problem is on MoveSpline, same happens when you charge with warriors against any mob, this is fixed on TC master

Motorheadx commented 6 years ago

I found the reason for what falls.If he always moves without stopping on this hill all is fine he doesn't fall but as soon as stnovitsya something to attack it falls under land

BarbzYHOOL commented 6 years ago

give the TC commit fix

Also pets (and other mobs) often fall into a hole lol

Motorheadx commented 6 years ago

I ran some tests and realized that the problem is really npc 36892.In the file pit_of_saron for fun, I changed the npc to another 36830 it no longer fell.Then I tried to create my monster and just put it in the code and it worked fine, maybe where the error is with npc 36892 but I can't figure out where exactly I tried to disable SmartAI all the same it fell after that

ghost commented 6 years ago

I've seen this happen when I scripted waypoints for any npc. If the waypoint was too long the mob simply calculated the closest path to the next point which made him clip with textures. Also on climbs this usually happens aswell so got to use more points to avoid this. It's almost as if the diff variable blew up.

This can probably be hotfixed/hacked with simply using more waypoints even though it isn't an optimal fix.

Note: In some textures we can also find pets clipping with terrain or standing way above it when they should just be standing on them.

Motorheadx commented 6 years ago

it's not about waypoints, it's a great way to move around on points, it starts to fall during the battle when it stops to cast a spell

and I repeat that the problem is with this creature id 36892 if you make the code any other ID creation the problem disappears

Nefertumm commented 6 years ago

EDIT: We have those commits already.

BarbzYHOOL commented 6 years ago

We already have it https://github.com/azerothcore/azerothcore-wotlk/blob/master/src/server/game/Entities/Object/Object.cpp

ghost commented 6 years ago

CONFiRM

BarbzYHOOL commented 6 years ago

Can someone confirm with the newest commit and mmaps? 8e9faf848865769d8e1d851889f04eae07fb976a

boom8866 commented 6 years ago

The problem is, when the creature and your distance move down, the creature moves forward and falls.

Motorheadx commented 6 years ago

I checked the new mmaps do not fix this problem

mynew4 commented 5 years ago

https://github.com/azerothcore/azerothcore-wotlk/blob/master/src/server/game/Movement/MovementGenerators/TargetedMovementGenerator.cpp#L101 I think the problem is from here.