search

azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.41k stars 2.57k forks source link

Various issues with "Talisman of Ascendance" #8676

Open Shineslippers opened 2 years ago

Shineslippers commented 2 years ago

What client do you play on?

enUS

Faction

Content Phase:

Current Behaviour

Original report: https://github.com/chromiecraft/chromiecraft/issues/2164

After using stacks on every spell cast and spell tick (for example blizzard tick, mind flay tick, dots etc). Doesn't count casted shields like Ice Barrier.

Tester: Talisman of Ascendance where Consumable(Inital) Ascendance ID28200 buff and Accumulating Ascendance ID28204 buff.

  1. Checked out issue on mage and priest, can confirm it. Using shields doesn't consuming or accumulating stacks of buffs.
  2. If you cancel Consumable buff it will cancel also Accumulate buff, but not vice versa
  3. HoTs and DoT's using one stack after usage.
  4. Multiple target spells like Priest's Holy Nova; Shaman's Chain Heal and Chain Lightning; Mage's Arcane Explosion and etc. using stack for EACH target.
  5. Channeling spells like Mind Flay and Arcane Missiles using stack for EACH tick.

https://user-images.githubusercontent.com/85256266/138377212-10ab313f-fb0c-4e8a-848b-3ed7635cdc1f.mp4

https://user-images.githubusercontent.com/85256266/138377223-ee234795-75c1-448c-b06f-da7822555ca5.mp4

Expected Blizzlike Behaviour

When activated, it starts stacking from every spell cast. It counts channelled spells and Overtime spells as one cast, not multiple single casts(for example 1 Channeled Blizzard cast counts for 1 casted spell for trinket), should count absorb spells like shields when cast on yourself or others.

Tester:

  1. Description saying Your next 5 damage or healing spells cast within 20 seconds. I guess you can interpreting it like spells what have scale from spell power. Shields is getting benefits from stacks of spell power. Logically it should using stacks. Found Wowhead comment also:

    By Smegmantha on 2006/07/18 (Patch 1.11.2) I haven't tested it in every situation as of yet, but came up with a neat technique for farming elites. I pop the trinket, cast PW:S on myself (starts the +dmg/heal stacking), cast four damage spells, then use the last and largest charge to place a Renew on myself as I wand them to death. The final charge has a generous +375 healing on it, so the self renew has big enough ticks to cancel out damage caused by an elite!

  2. Wowpedia Patch 1.12.0 (2006-08-22): In addition, if either of the buffs from the item are canceled, they will both be canceled.

  3. Look like with HoTs and DoTs everything good. Wowhead have comment like this:

    By Jelir on 2006/08/24 (Patch 1.12.0) CoA (+0) Corruption (+40) -> (+40) Immolate (+80) -> (+68) Shadow Bolt (+120) -> (+103) Conflag (+160) -> (+69) Shadowburn (+200) -> (+86)

  4. Regardless of everything it's weird. Didn't find anything what saying it should using stacks for each target.

  5. It's not so weird but still looks like wrong.

Source

Wowhead shields comment Wowhead dots comment Wowpedia Talisman of Ascendance

Steps to reproduce the problem

.addi 22678 and use various spells

Extra Notes

Tested also Zandalarian Hero Charm. Same issues with Multiple target spells. I guess issue could be regarding to stackable buffs in general.

AC rev. hash/commit

https://github.com/chromiecraft/azerothcore-wotlk/commit/e9c71c8ebefc067e3119a2a1a63b74c3239cc55c

Operating system

Ubuntu 20.04

Modules

Customizations

None

Server

ChromieCraft

--- Want to back this issue? **[Post a bounty on it!](https://app.bountysource.com/issues/106210529-various-issues-with-talisman-of-ascendance?utm_campaign=plugin&utm_content=tracker%2F40032087&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://app.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F40032087&utm_medium=issues&utm_source=github).
15414h commented 2 years ago

I bought this 'Talisman of Ascendance' for my Affliction Warlock, and I am SUPER DISAPPOINTED. It does not work as described at all. Instead of getting the promised +40SP increase for your next 5 spells it is also being triggered by any effects that appear on the enemy - like it triggers on Shadow Embrace (a flat 5% dmg increase) where the increased SP has ZERO benefit. After casting 2 Shadowbolts, the Ascendence was already over... PLEASE FIX THIS! see attacked screenshots for combat log WoWScrnShot_032322_024704 !