azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.62k stars 2.64k forks source link

Summoned creature's level should scale according to the summoner's level and summon spell #8945

Open Nyeriah opened 3 years ago

Nyeriah commented 3 years ago

Current Behaviour

Summons always inherit their level from creature_template, regardless of the summoner's level (e.g Moonstalker Runts, Fen Dwellers)

Expected Blizzlike Behaviour

For example, Moonstalker Matriarches should spawn minions three levels lower than them. So a level 20 matriarch spawns a level 17 cub, 19 spawns a 16 one.

https://classic.wowhead.com/npc=2071/moonstalker-matriarch#comments

I went and checked them, and the cubs spawned by the Moonstalker Matriarchs follow the creature level from creature_template.

I've found this though:

Skärmbild 2021-10-06 141221

Several other summon spells have negative multiples, coincidently, the creatures they summon have a tendency to have their level comprised of caster level - spell multiple.

For example: Spell: Summon Water Elemental (https://classic.wowhead.com/spell=17162), Multiple = -2 Used by creature: Crimson Conjuror (level: 57-58) Spawns: Water Elemental (level: 55-56)

It's early to tell if there's a relation between that, but it seems to me that there might be.

Source

No response

Steps to reproduce the problem

go to creature 2071 notice they spawn level 11 mobs

Extra Notes

No response

AC rev. hash/commit

https://github.com/azerothcore/azerothcore-wotlk/commit/da424267830b57c17f6804dc3bdb9dce248e513f

Operating system

Win11 x64

Custom changes or Modules

No response

Nyeriah commented 3 years ago

@T1ti do you have any information on this you could share?

Shineslippers commented 3 years ago

I just wanna point again to Moonstalkers. There is summoned one: https://youtu.be/Kx9YWaQmnt8?t=407 https://youtu.be/AX2yrGoVxzM?t=5

There is free one: https://youtu.be/IPGahhdXQqc?t=29 https://youtu.be/-b5a2FKz-WE?t=32

And wowhead confirming levels: https://tbc.wowhead.com/npc=2070/moonstalker-runt

Conclusion. I will repeat. Those who is summoned creature should have comparable level to summoner, but other who is not summoned can be any level.

PR's is correct but need some fix to summoned creatures: https://github.com/azerothcore/azerothcore-wotlk/pull/8210 https://github.com/azerothcore/azerothcore-wotlk/pull/8002

T1ti commented 3 years ago

I just wanna point again to Moonstalkers. There is summoned one: https://youtu.be/Kx9YWaQmnt8?t=407 https://youtu.be/AX2yrGoVxzM?t=5

There is free one: https://youtu.be/IPGahhdXQqc?t=29 https://youtu.be/-b5a2FKz-WE?t=32

And wowhead confirming levels: https://tbc.wowhead.com/npc=2070/moonstalker-runt

Conclusion. I will repeat. Those who is summoned creature should have comparable level to summoner, but other who is not summoned can be any level.

PR's is correct but need some fix to summoned creatures: #8210 #8002

your first video is private server footage

your 3rd video is from a private server 4th video is from a private server too

Please stop using private server footage

Shineslippers commented 3 years ago

Fair

T1ti commented 3 years ago

But yes the original issue is true, the summoned creature level should he caster's level -/+ multiple value

Gultask commented 2 years ago

https://github.com/chromiecraft/chromiecraft/issues/3686 Tereneckla shared some more sources: https://youtu.be/XxviCVvlIis?t=76 from retail 2015 showing that the Shadowpine Catlord and their Ghostclaw Lynx should have a -3 level difference. https://youtu.be/wS2zGc5I1pA?t=103 from TBC Classic confirms the -3 level difference.

heyitsbench commented 2 years ago

Could possibly be related to https://github.com/azerothcore/azerothcore-wotlk/issues/12641, specifically 4/256.