azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.55k stars 2.62k forks source link

Disenchant rolls with full bags #9256

Closed IntelligentQuantum closed 2 years ago

IntelligentQuantum commented 2 years ago

What client do you play on?

enUS

Faction

Content Phase:

Current Behaviour

Original Post: https://github.com/chromiecraft/chromiecraft/issues/2360

When you click disenchant on an item role in RDF or dungeon and you have full bags, if you win the item, it just disappears. No enchanting mats stay behind and the item is gone.

Expected Blizzlike Behaviour

the item stays on the body for you to clear your inventory

Source

No response

Steps to reproduce the problem

  1. have full inventory
  2. hit disenchant on an item roll
  3. win item roll
  4. lose item

Extra Notes

No response

AC rev. hash/commit

https://github.com/chromiecraft/azerothcore-wotlk/commit/00dc369cb627d728c520cd597b31e9edf2c75eed

Operating system

Ubuntu 20.04

Modules

Customizations

None

Server

ChromieCraft

Ollie-Armitage commented 2 years ago

@IntelligentQuantum Just to confirm is that the item, or the mats that should stay on the body?

Nyeriah commented 2 years ago

@IntelligentQuantum Just to confirm is that the item, or the mats that should stay on the body?

This is wrong, the mats get sent to your mail (item recovery mail), I've implemented this before, and it used to work