Engulfing Shadows of Blade of Eternal Darkness doesn't crit

[Shineslippers]

What client do you play on?

enGB

Faction

• [X] Alliance
• [X] Horde

Content Phase:

• [ ] Generic
• [ ] 1-19
• [ ] 20-29
• [ ] 30-39
• [X] 40-49
• [ ] 50-59

Current Behaviour

Original report: https://github.com/chromiecraft/chromiecraft/issues/2418

Supposedly proc should be able to crit but does not work on this server. Proc damage is flat 100. It should be able to crit for 200 damage. It should not be affected by crit amplifier talents though. Critical chance should be determined by how much spell critical chance one character has. Mana return is working properly. Does not proc of DoTs which works correctly. Only of direct damage and this is also good. Proc damage is not affected with spell power which is working correctly. It is affected by Shadow form and Shadow Weaving talents which also works correctly. Out of 220+ proc from couple of days ago in dungeon i did not have a single crit. I wish this can be fixed so many people can enjoy this sweat and rare epic weapon while it last. Once we get into Molten Core there will be much stronger options and upgrades and sadly this beautiful dagger will most likely collect dust in bank.

Tester:

The issue is confirmed. Blade of Eternal Darkness's Engulfing Shadows or Engulfing Shadows doesn't crit. Idk which should

Expected Blizzlike Behaviour

To correct it so 100 shadow damage proc can crit for flat 200 damage.

Source

Wowpedia Blade of Eternal Darkness

The damage can also crit but has its own rate. The mana regenerated cannot be increased.

Wowhead Blade of Eternal Darkness

By 78063 on 2007/09/09 (Patch 2.1.3) I have 255dmg/heal, and it still hits for only 100 and it will still only give me 100 mana. I have seen it crit for 200 a few times, though I'm not sure if it would only be 150 if I didn't have talents to make my crits do 100% damage, not just the normal 50% for spells.

Steps to reproduce the problem

.cast 27860

.aura 21978 .cast 585

Extra Notes

No response

AC rev. hash/commit

https://github.com/chromiecraft/azerothcore-wotlk/commit/fc16abc30ea2e9412627ddd9d15868eac8aabb53

Operating system

Ubuntu 20.04

Modules

• mod-ah-bot
• mod-cfbg
• mod-chat-transmitter
• mod-chromie-xp
• mod-desertion-warnings
• mod-duel-reset
• mod-eluna-lua-engine
• mod-ip-tracker
• mod-low-level-arena
• mod-multi-client-check
• mod-pvp-titles
• mod-pvpstats-announcer
• mod-queue-list-cache
• mod-server-auto-shutdown
• lua-carbon-copy
• lua-custom-worldboss
• lua-level-up-reward
• lua-recruit-a-friend
• lua-send-and-bind
• lua-temp-announcements
• lua-zonecheck
• lua-zone-debuff

Customizations

None

Server

ChromieCraft

[avarishd]

Could possibly be due to SPELL_ATTR0_CU_CAN_CRIT custom attribute missing. (Trinity has it)