search

azerothcore / mod-1v1-arena

1v1 Arena Module AzerothCore
GNU General Public License v3.0
15 stars 53 forks source link

Is there a way to NOT disable 5v5 arenas? #13

Closed BarbzYHOOL closed 1 year ago

BarbzYHOOL commented 4 years ago

Just being curious

peti446 commented 4 years ago

@BarbzYHOOL Yes there is, but it requires some patching on the core side to create the 1v1 queue.However it has a drawback the 1v1 team will not appear in the UI where 5v5,3v3 and 2v2 is. Also for old servers using this modules the 5v5 team composition would be needed to be migrated to 1v1 (changing the type from 5 to 1 on arena_team and in haracter_arena_stats from 2 to 3 (Assuming it was using the 5v5 braket for 1v1)).

The patch for core can be found here: https://github.com/peti446/azerothcore-wotlk-1/commit/f7e594fd849c28d2953d2d1a6e989de10ddb356d

And the patch for this module here: https://github.com/peti446/mod-1v1-arena/commit/6202352c918007b49e856ac3b64a5379270e9bff

This also fixes https://github.com/azerothcore/mod-1v1-arena/issues/12 and https://github.com/azerothcore/mod-1v1-arena/issues/15

Helias commented 4 years ago

@peti446 what about to some PRs? :P

EDIT: oh but you are modifying the core for this module, you should try to do not touch the core, or make it more configurable

peti446 commented 4 years ago

@Helias The core changes are used to creates a new queue for the 1v1, I am not aware to get this code into a module by itself.

All the custom code will only be in effect if the actual module is installed otherwise it will not compile it (usage of define "mod_1v1arena", similar to how eluna did it).

Kinda new to the project so, with more configurable, what is the scope here to get the changes allowed into the core?

Helias commented 4 years ago

I know that the way you modified the core does not affect the core itself if you do not use the arena 1v1 module, but, I think that there is an easy way to avoid that

We use that way only for important modules like Eluna or CFBG, for the others, we want to avoid this kind of code but only allow possible extension/module without using #ifdef / #define etc.

pangolp commented 1 year ago

What is the current status of this issue, has it been resolved or does the problem persist? The module has had some updates, but I don't know if all the issues have been fixed. I look forward to hearing from you. Thank you.

pangolp commented 1 year ago

Greetings, by the date of publication of the issue, I would say that this issue is already resolved. If not, please reopen a new issue, attaching information so that we can solve the problem. Thank you very much.