search

azerothcore / mod-1v1-arena

1v1 Arena Module AzerothCore
GNU General Public License v3.0
15 stars 53 forks source link

feat(patch): Arena Crystals fix #18

Closed Rastrian closed 3 years ago

Rastrian commented 4 years ago

Based on issue(s) https://github.com/azerothcore/mod-1v1-arena/issues/15 https://github.com/azerothcore/mod-1v1-arena/issues/13 https://github.com/azerothcore/mod-1v1-arena/issues/12

Added some fixes provided by https://github.com/peti446

The unrated arena was been removed from the 5v5 method. Added a new config file with the option for change the method. The patch don't change too much about the actual azerothcore structure and can be disabled without any problem. The arena crystals work fine with both modes (using 5v5 arenas and 1v1 arenas).

Patch Pastebin Link: https://pastebin.com/Jw8XexQy

asfo commented 4 years ago

Conflicts when apply the patch (line 136 in the .patch file) maybe because a recent change in AC...

Rastrian commented 4 years ago

Conflicts when apply the patch (line 136 in the .patch file) maybe because a recent change in AC...

I will fix this later but thx

peti446 commented 4 years ago

@Rastrian I just noticed yesterday, that one of the changes I made will cause some visual bugs on the client due to a limit in player data being sent. So this changes will cause rune cd not to be displayed and glyphs to show as disabled based on you arena team data if you happen to have the right values you do not see this problem .... I was lucky I guess!

I am working on some changes that will resolve this issue and hopefully encapsulate it all in a module (just script hooks in core) to be less destructive on core. Hopefully by the weekend I should have something limited time right now

Rastrian commented 4 years ago

@Rastrian I just noticed yesterday, that one of the changes I made will cause some visual bugs on the client due to a limit in player data being sent. So this changes will cause rune cd not to be displayed and glyphs to show as disabled based on you arena team data if you happen to have the right values you do not see this problem .... I was lucky I guess!

I am working on some changes that will resolve this issue and hopefully encapsulate it all in a module (just script hooks in core) to be less destructive on core. Hopefully by the weekend I should have something limited time right now

Okay :)

I will fix the patch too.