azerothcore / mod-1v1-arena

1v1 Arena Module AzerothCore
GNU General Public License v3.0
15 stars 53 forks source link

feat. Upgrade module to latest kernel version #45

Closed pangolp closed 1 year ago

pangolp commented 1 year ago
Helias commented 1 year ago

good job man!

pangolp commented 1 year ago

good job man!

We have to try to put the template, to most of the modules, because if not, many times we do not have the necessary information, to be able to know what the problem is, and try to solve it.

Helias commented 1 year ago

About the template issue or PR I was wondering if it is possible to create a "reusable template" like the reusable workflows for the github action, like a centralize issue_template.md file in one single repository used from many other repositories, instead of copy/paste the same template into all modules

pangolp commented 1 year ago

About the template issue or PR I was wondering if it is possible to create a "reusable template" like the reusable workflows for the github action, like a centralize issue_template.md file in one single repository used from many other repositories, instead of copy/paste the same template into all modules

In fact, the current mod-skeleton, already has the issue and pull_request built in. It happens that for these old modules, you have to do it manually. But the new modules come with the templates and other configurations. It was added precisely in this commit, to avoid having to do that, but it only works for the new modules. The old ones, we have to update them manually, "I think". https://github.com/azerothcore/skeleton-module/commit/3b4bfd24231079a93310d7a17cdc3e2af9238adc