search

azerothcore / mod-1v1-arena

1v1 Arena Module AzerothCore
GNU General Public License v3.0
15 stars 53 forks source link

Fix issue with leaving queue #5

Closed ELdoBA closed 5 years ago

ELdoBA commented 5 years ago

Closes: https://github.com/azerothcore/mod-1v1-arena/issues/2

https://github.com/azerothcore/mod-1v1-arena/issues/3#issuecomment-519862790

Helias commented 5 years ago

This PR contain code duplicate of https://github.com/azerothcore/mod-1v1-arena/pull/4/

immagine

I think we could close this and focus on https://github.com/azerothcore/mod-1v1-arena/pull/4/ that contains more improvements, do you agree? @poszer, @Winfidonarleyan?

ELdoBA commented 5 years ago

This PR contain code duplicate of #4

immagine

I think we could close this and focus on #4 that contains more improvements, do you agree? @poszer, @Winfidonarleyan?

Screenshot_2

ELdoBA commented 5 years ago

This PR contain code duplicate of #4

immagine

I think we could close this and focus on #4 that contains more improvements, do you agree? @poszer, @Winfidonarleyan?

And to be clear, this commit is created before other one, tested and confirmed as working one

masterking32 commented 5 years ago

tested and working. I can correctly leave the Arena Queue clicking on NPC gossip

Helias commented 5 years ago

We could merge both PRs to give the credits to both.

FrancescoBorzi commented 5 years ago

agree, please merge both

milestorme commented 5 years ago

Thank you @poszer can merge this

FrancescoBorzi commented 5 years ago

for some reasons squash failed, it merged without squashing commits

ELdoBA commented 5 years ago

for some reasons squash failed, it merged without squashing commits

The other PR is not needed. The module works now perfectly except Skirmish. And other PR commit wont fix it

FrancescoBorzi commented 5 years ago

@Poszer please discuss it in the other pr, not here. I don't have time to check it now