File AnticheatMgr.cpp: Clean a little bit the code. Moved some conditions so they don't get evaluated if they are not needed.
The rest of the changes are on the file cs_anticheat.cpp...
Clean some code (removed some redundant comments, some .c_str() were unecessary).
Remove lots of duplicate handler->PSendSysMessage(...) in the anticheat player command (found in the HandleAntiCheatPlayerCommand function)
Rename the Ignore Anti-Swim Reports to Anti-Swim Reports.
Prevent the spam of Macro Requiring Lua Unlock Detected: Yes by removing a do-while loop.
The resultADB, resultCDB and resultLDB queries no longer gives unused elements.
Mute the following reports if the player has no report: speed, flight, jump, waterwalk, teleport to plane, teleport, climb, ignorecontrol, zaxis, antiswim, gravity, antiknockback, no fall damage and op ack. In the process, speed, many of them were regrouped together on the same line but they are now on separate lines.
Issues Addressed:
Closes nothing.
SOURCE:
Tests Performed:
Used anticheat delete Syn from the console and ingame while Syn was online.
Used anticheat player Syn from the console and ingame while Syn was online.
How to Test the Changes:
Install stuff and pray it didn't turn your computer into a crypto miner or worse.
Do stuff.
anticheat player and anticheat delete
Known Issues and TODO List:
Needs testing from someone with actual cheats, or use some false positives.
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.
Changes Proposed:
AnticheatMgr.cpp: Clean a little bit the code. Moved some conditions so they don't get evaluated if they are not needed.cs_anticheat.cpp....c_str()were unecessary).handler->PSendSysMessage(...)in theanticheat playercommand (found in theHandleAntiCheatPlayerCommandfunction)Ignore Anti-Swim ReportstoAnti-Swim Reports.Macro Requiring Lua Unlock Detected: Yesby removing a do-while loop.resultADB,resultCDBandresultLDBqueries no longer gives unused elements.Issues Addressed:
SOURCE:
Tests Performed:
anticheat delete Synfrom the console and ingame whileSynwas online.anticheat player Synfrom the console and ingame whileSynwas online.How to Test the Changes:
anticheat playerandanticheat deleteKnown Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.