Improvement against a speed hack false positive because the server was expecting the player to be moving at a slower speed before the player knew they had to move slower such as the loss of a speed increase buff or receiving a slow debuff.
Fix against speed hack false positive by using the Blink spell by adjusting the traveled distance (20.1y or 25.1y glyphed, includes a miscalculation adjustments).
Fix against speed hack false positive by using the Shadowstep (25y only) spell by adjusting the traveled distance.
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.
Changes Proposed:
Blink
spell by adjusting the traveled distance (20.1y or 25.1y glyphed, includes a miscalculation adjustments).Shadowstep
(25y only) spell by adjusting the traveled distance.Issues Addressed:
Tests Performed:
Shadowstep
no longer trigger the speed hack false positives at mid range.Dazed
is now very difficult to trigger the speed hack false positive.How to Test the Changes:
Known Issues and TODO List:
Shadowstep
can go because it will still trigger if you try on Onyxia at max range.How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.