Tracks the player's previous mapid so it would no longer trigger speed false positive from repeatedly entering/leaving an instance such as Gnomeregan.
Remove the silly same X-axis ignore condition in the teleport hack detection: It would be bad to ignore someone using a teleport hack by changing only the Y-axis because the X-axis hasn't changed.
Remove unused tracking of the mapid from the AnticheatMgr.h file because this file it is not related to the current player.
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.
pangolp
commented
1 year ago
Changes Proposed:
AnticheatMgr.hfile because this file it is not related to the current player.Issues Addressed:
https://github.com/azerothcore/mod-anticheat/assets/22718174/1794197b-7547-484b-9382-ed34df07d006
Tests Performed:
How to Test the Changes:
.anticheat playerKnown Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.