Closed pangolp closed 1 year ago
The anticheat module uses its own update system that needs to be removed if you’re going to use the default auto updater
The anticheat module uses its own update system that needs to be removed if you’re going to use the default auto updater
Ah, I didn't know that information. Is this change wrong then?
Even though I have merge permissions, I will not approve this change, even though it passes the tests. I leave it in your hands, let them decide if it is useful or not. If not, we go back to the previous files. However, I think I'm going to use it.
Having never used the anticheat so far, this works for me. Perhaps some project, which is already using it, will not use it. Obviously, I don't want to harm anyone. But use the pull request anyway, if it doesn't apply.
Disregard what I said as it was already removed
Disregard what I said as it was already removed
The include? Yeah.
The issue is knowing if this affects in any way the projects that already have the anticheat. It works for new users, but for those who are already using it, I don't know.
Thanks @Nyeriah
Changes Proposed:
Issues Addressed:
SOURCE:
Tests Performed:
How to Test the Changes:
Known Issues and TODO List:
Screenshot
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.