search

azerothcore / mod-aoe-loot

Loot all bodies at once!
GNU Affero General Public License v3.0
27 stars 26 forks source link

Feature: Stop picking up when the backpack is full #13

Closed icaca closed 1 year ago

icaca commented 1 year ago

Describe your feature request or suggestion in detail

Is it possible to add a setting, when the user's backpack is full, the aoe loot will be suspended and no email will be sent

Describe a possible solution to your feature or suggestion in detail

No response

Additional context

No response

pangolp commented 1 year ago

Possible is. But we will have to see if it works. Why would it be necessary to get out of the execution. Then I'll see if I can do something, but they're going to have to try it.

icaca commented 1 year ago

Because we developed a hardcore mode, players can not receive mails, but we want them to quickly pick up

pangolp commented 1 year ago

Because we developed a hardcore mode, players can not receive mails, but we want them to quickly pick up

It would be necessary to test, because the mod is very recent. I'll see if around the weekend I can sit down and do some testing. Anyway, the mod is public, if you want to try it and upload the solution, we review it and if it works, we approve it.

icaca commented 1 year ago

Ok, I will try to modify it. I used eluna for module development before, and I don’t know much about the interface of C++.

pangolp commented 1 year ago

Ok, I will try to modify it. I used eluna for module development before, and I don’t know much about the interface of C++.

There was a time when I didn't know how to do it either. But if you don't try, you'll never know what you can do. The important thing is to share it with others. Because as it is configurable, it can be useful to other people. As long as it is optional and not mandatory.

pangolp commented 1 year ago

I just made a pull request on the subject, I tested it on the local server and it works. But keep in mind, if the player has full bags, the mail is not sent, but the items are lost. To avoid this, we will have to make additional modifications, but that is the subject of another pull request. In this one, we only solve the issue of enabling or disabling the sending of mails.

pangolp commented 1 year ago

The mail is not sent, but the item disappears. https://github.com/azerothcore/mod-aoe-loot/assets/2810187/edafef47-dbd2-4520-8d73-520aa00bc4eb