search

azerothcore / mod-aoe-loot

Loot all bodies at once!
GNU Affero General Public License v3.0
28 stars 31 forks source link

Bug: Cant loot quest items. #24

Closed brunolopes1996 closed 8 months ago

brunolopes1996 commented 8 months ago

Current Behaviour

Human starting zone, Wolf meat quest, you requiete a stack of 8 items droped by the wolfs. I kill the wolfs they do show the item in the loot plus other items the mob drops, i click to loot the items all the items get into my bags except the quest item that just vanishes. ( it does not go to the mail it does not go to my bags and it does not count to the quest complition) if i turn the module off everything works as intended i can loot the mob take the items requiered for the quest.

Expected Behaviour

The item should appear on my bag and count for the quest completition when looted

Steps to reproduce the problem

Create a human, take the wolf meat quest on the starting zone and try to loot the requested items to complete the quest

Extra Notes

No response

AC rev. hash/commit

https://github.com/trickerer/AzerothCore-wotlk-with-NPCBots cloned 19/02/2024

Operating system

windows

Custom changes or Modules

pangolp commented 8 months ago

The module is still in development, although what you mention should not happen. Later, I will clone the repository and try what you mention. Thanks for the report. I am going to do the tests on the latest version of AzerothCore, the official one and only with the area loot module. Because we have a theme regarding items, to prevent it from taking those that are unique, but I don't think that's the case, that's why I need to do tests later.

pangolp commented 8 months ago

Unfortunately, the problem is in a mechanic that we implemented, because if we used the original, sometimes, in certain circumstances, it gave us more items than usual. The problem is that if we go back to that mechanic, to enable the quest items issue, we are going to have that other problem. So it's time to investigate a little more in detail.

pangolp commented 8 months ago

I think I found the fault. There are 2 vectors.

std::vector<LootItem> items;
std::vector<LootItem> quest_items;

I am only using the first one, so surely, in the second one, there are all the mission items, and for that reason, they are not being delivered. It's not that serious I think, it may be easy to repair it.