search

azerothcore / mod-aoe-loot

Loot all bodies at once!
GNU Affero General Public License v3.0
28 stars 31 forks source link

Update README.md #35

Closed Kaev closed 7 months ago

Kaev commented 7 months ago

Changes Proposed:

Issues Addressed:

pangolp commented 7 months ago

This information is not 100% correct. If we're going to edit the README, that's fine with me. But I've been trying to make this work for 2 years, creating the hooks, testing the code, making changes to it and I didn't get into the credits, to give a little to everyone. That's why I didn't name anyone in particular. I don't think it's fair to do so. We'll have to name them all. By seeing the commits and pull requests, you will be able to deduce who wanted this to work and make it a reality today.

pangolp commented 7 months ago

I would like to know in what context this discussion was generated. Because now the only thing missing is for them to believe that I don't want to recognize certain people. I have updated more than 100 modules, and I did not give myself credit, not even in a single one of them. Now I have the doubt, why it was necessary to specifically name a person who participated, as several of us participated, but she was not the only one and that the code is not 100% that seen in the pull request that is mentioned.

FrancescoBorzi commented 7 months ago

@pangolp this was generated by Acidmanifesto requesting to get credits for his prior work.

All contributors, including yourself, are automatically listed in https://github.com/azerothcore/mod-aoe-loot/graphs/contributors

the problem is that because of the way the code was added, Acidmanifesto did not get to that page, that is why we are making an exception and mentioning him in the README. For the other contributors, this is not needed as they regularly appear in the Contributors list that GitHub nicely generates for us automatically, including statistics about lines of code etc..

pangolp commented 7 months ago

@pangolp this was generated by Acidmanifesto requesting to get credits for his prior work.

All contributors, including yourself, are automatically listed in https://github.com/azerothcore/mod-aoe-loot/graphs/contributors

the problem is that because of the way the code was added, Acidmanifesto did not get to that page, that is why we are making an exception and mentioning him in the README. For the other contributors, this is not needed as they regularly appear in the Contributors list that GitHub nicely generates for us automatically, including statistics about lines of code etc..

Good. I understand. But I read the original message and it seemed that I didn't want to give credits or something like that and I say... the only thing missing is that you believe that I am stealing other people's ideas at this point in my life... obviously, I misunderstood the pull request, but it sounded really strange when I read it. Thanks for the clarification.