search

azerothcore / mod-aoe-loot

Loot all bodies at once!
GNU Affero General Public License v3.0
28 stars 31 forks source link

Bug: Module overrides other modules #38

Open Tilenozz opened 7 months ago

Tilenozz commented 7 months ago

Current Behaviour

After the last fixs, all is working good , except this overrides other modules that concern calculation of money loot. ( mod guild funds )

Expected Behaviour

create a % of gold to give to guild bank

Steps to reproduce the problem

Complete a quest or kill creature that give money

Extra Notes

No response

AC rev. hash/commit

AzerothCore rev. fb4a11e5d1f1 2024-02-26 20:56:55 +0000 (master branch) (Unix, RelWithDebInfo, Static)

Operating system

Ubuntu 20.04

Custom changes or Modules

No response

pangolp commented 1 month ago

Hello, good day. The repository has been updated recently, so we don't know if this last change still affects this issue or not. Please, if you can share with me the link of the repository you are mentioning, so I can test it, and in any case, let me know so that this issue can be closed, if it was successful. Thanks.

I tried to contact the developer, and look for the code of the module you are mentioning, but I did not find anything about it. It would be good to have the URL of the repository, so I can clone it and test it.

pangolp commented 1 month ago

I'm waiting for the creator of the mod to accept or not this change, but to make changes to the code that the module currently has and is fully compatible between both. https://github.com/noisiver/mod-guildfunds/pull/3 so this report would not be valid due to the latest changes in this repository. It could already be considered solved.