azerothcore / mod-autobalance

Module for AzerothCore(MaNGOS -> TrinityCore -> SunwellCore)
http://www.azerothcore.org
102 stars 109 forks source link

Feat/Fix: Dynamic creature levels, reworked reward scaling, many fixes and improvements #133

Closed kjack9 closed 1 year ago

kjack9 commented 1 year ago

This (large) PR adds multiple new features to mod-autobalance.

I propose that this PR updates the module version to v2.2.0, but it does have several variables that are deprecated or outright removed. I have supported the old variable names where it is practical, but there are changes in functionality that may create different results from before. I am open to calling this v3.0 is that is deemed more appropriate.

Looking forward to your testing and questions.

Helias commented 1 year ago

I did not work on this module so I can't make a full review of the code, the PR looks good to me, but I would wait some other reviewers

pangolp commented 1 year ago

Particularly, I work with smaller PR. However, in some cases I understand that it is not possible. Because I haven't worked in the module enough. To understand the difference, between the current and the change you propose. Beyond the explanation found in the PR, which is fine I think. Helias, considers that it is fine, and I think so too. But neither of us, we have worked enough... We could approve it, and in any case, reverse it. But if you can explain to me the difference, maybe it would be better.

kjack9 commented 1 year ago

Particularly, I work with smaller PR. However, in some cases I understand that it is not possible. Because I haven't worked in the module enough. To understand the difference, between the current and the change you propose. Beyond the explanation found in the PR, which is fine I think. Helias, considers that it is fine, and I think so too. But neither of us, we have worked enough... We could approve it, and in any case, reverse it. But if you can explain to me the difference, maybe it would be better.

We discussed on Discord and I believe @pangolp has what they need now. Let me know if that's not the case.

pangolp commented 1 year ago

Thanks for the PR.