search

azerothcore / mod-autobalance

Module for AzerothCore(MaNGOS -> TrinityCore -> SunwellCore)
http://www.azerothcore.org
102 stars 109 forks source link

Trial of the crusader: faction champions' stats are not scaled down #144

Closed WangDianhui closed 12 months ago

WangDianhui commented 1 year ago

Describe your feature request or suggestion in detail

If there are characters whose reputation with Argent Crusade is friendly or more in the instance, the faction champions' stats would not be scaled.

Neutral with Argent Crusade Friendly with Argent Crusade
pangolp commented 1 year ago

How strange that he does not climb with the champions ... I haven't really used this module, it has many configurations... I'll have to try it.

cdenq commented 1 year ago

Is your party cross-faction by any change? Scaling will apply properly if everyone is the same faction.

kjack9 commented 1 year ago

I want to wait until #155 is merged and then troubleshoot this if its still happening - that will give us some more detail via the .ab mapstat and .ab creaturestat commands.

WangDianhui commented 1 year ago

This problem still exists. I have already pulled the latest commit for both server and mod. 1 2 3 The champions' HP does not change as the num of players changes.

WangDianhui commented 1 year ago

I think I've found the problem...

4

If the party leader's name contains chinese characters, the champions' stats would not be changed. But for English names, the mod works properly.

kjack9 commented 1 year ago

Wow, I have no idea what could possibly be causing that. The mod doesn't care about character names for making decisions. It DOES have character names in some of the announcements, but I can't think of why that would matter. I don't even know where to begin on troubleshooting this.

Marking "Help Wanted" for now.

WangDianhui commented 1 year ago

I've confirmed that the problem is independence with the name. But it just occurred when there are some SPECIFIC characters in the instance, no matter who the party leader is.

I'm still looking for the trigger condition.

WangDianhui commented 1 year ago

Confirmed. If there are characters whose reputation with Argent Crusade is friendly or more in the instance, the faction champions' stats would not be scaled.

Neutral with Argent Crusade Friendly with Argent Crusade
kjack9 commented 1 year ago

I've added this to my personal backlog.

kjack9 commented 12 months ago

@WangDianhui can you please test with the latest version of AC and AutoBalance and let me know if the issue is still happening?

WangDianhui commented 12 months ago

@WangDianhui can you please test with the latest version of AC and AutoBalance and let me know if the issue is still happening?

Tested, the problem has gone. Champions' scaling are now irrelevant with reputation.

kjack9 commented 12 months ago

@WangDianhui can you please test with the latest version of AC and AutoBalance and let me know if the issue is still happening?

Tested, the problem has gone. Champions' scaling are now irrelevant with reputation.

Great! Closing as confirmed fixed by #157