search

azerothcore / mod-autobalance

Module for AzerothCore(MaNGOS -> TrinityCore -> SunwellCore)
http://www.azerothcore.org
103 stars 109 forks source link

Bug: Attumen the Horseman's combined form shouldn't be detected as a clone of Attumen #161

Closed kjack9 closed 1 year ago

kjack9 commented 1 year ago

Current Behaviour

When Attumen and Midnight combine into a single unit, the current health value is being moved from the original Attumen unit to the new combined one.

Expected Behaviour

The new combined unit should start at full health. have its health managed by the boss script.

https://youtu.be/4x935w7XQbE?si=bx11JVXvOig66Blj&t=34

Steps to reproduce the problem

  1. Engage Midnight in Karazhan
  2. DPS Attumen ONLY down to 25%
  3. Observe that the new combined unit also has 25% health

Extra Notes

AutoBalance is (reasonably but incorrectly) estimating that the combined unit is a clone of the original, which in many cases means that the health and mana values should carry over. In this case, they should not.

AutoBalance Debug Commands

AC> AzerothCore rev. e94c67ccfeb2+ 2023-10-25 01:10:17 -0400 (zg-jeklik-improvements branch) (Unix, RelWithDebInfo, Static) Connected players: 2. Characters in world: 2. Connection peak: 2. Server uptime: 6 minute(s) 35 second(s) Update time diff: 13ms, average: 1ms. Using SSL version: OpenSSL 3.0.2 15 Mar 2022 (library: OpenSSL 3.0.2 15 Mar 2022) Using Boost version: 1.74.0 Using CMake version: 3.22.1 Using MySQL version: 80032 Found MySQL Executable: /usr/bin/mysql Compiled on: Linux 5.15.0-82-generic Worldserver listening connections on port 8085 Realmlist (Realm Id: 1) configured in port 8085 VMAPs status: Enabled. LineOfSight: 1, getHeight: 1, indoorCheck: 1 MMAPs status: Enabled maps directory located in /azerothcore/env/dist/data/maps. Total size: 291014951 bytes vmaps directory located in /azerothcore/env/dist/data/vmaps. Total size: 658130721 bytes mmaps directory located in /azerothcore/env/dist/data/mmaps. Total size: 2192910844 bytes Default DBC locale: enUS. All available DBC locales: enUS koKR zhCN zhTW esES ruRU Using World DB: ACDB 335.10-dev Latest LoginDatabase update: 2023_04_24_00.sql Latest CharacterDatabase update: trasmorg.sql Latest WorldDatabase update: world.sql LoginDatabase queue size: 0 CharacterDatabase queue size: 0 WorldDatabase queue size: 0

List enable modules:

  • mod-ah-bot
  • mod-assistant
  • mod-autobalance
  • mod-customlogin
  • mod-dead-means-dead
  • mod-eluna
  • mod-guildhouse
  • mod-item-level-up
  • mod-junk-to-gold
  • mod-learnspells
  • mod-npc-enchanter
  • mod-npc-free-professions
  • mod-npc-services
  • mod-reagent-bank
  • mod-skip-dk-starting-area
  • mod-solo-lfg
  • mod-transmog
  • mod-weapon-visual
  • mod-who-logged

AC rev. hash/commit

AC> AzerothCore rev. e94c67ccfeb2+ 2023-10-25 01:10:17 -0400 (zg-jeklik-improvements branch) (Unix, RelWithDebInfo, Static)

Operating system

Ubuntu 22.04

Custom changes or Modules

No response

kjack9 commented 1 year ago

Update: looks like it SHOULD inherit from the highest-health of Midnight OR Attumen. Right now AutoBalance is detected it as a clone of Attumen, so it is always setting health to that of Attumen. We should add a skip list in the module that does not detect the combined unit (16152) as a clone. Then we let the boss script do the work of actually adjusting the health.