azerothcore / mod-autobalance

Module for AzerothCore(MaNGOS -> TrinityCore -> SunwellCore)
http://www.azerothcore.org
102 stars 109 forks source link

Bug: Vaelastrasz the Corrupt appears with 100% health #170

Closed alca-00 closed 11 months ago

alca-00 commented 11 months ago

Current Behaviour

BWL Vael

Possibly similar to #164 Vaelastrasz is scaled down but appears at full health. Beginning the encounter & resetting it fixes him and places him at the intended 30% HP.

Expected Behaviour

Vaelastrasz the Corrupt should spawn with 30% health before the boss encounter begins.

Steps to reproduce the problem

.tele bwl /tar vael Check the boss health

Extra Notes

No response

AutoBalance Debug Commands

No response

AC rev. hash/commit

AzerothCore rev. fb83c22dd292+ 2023-11-02 12:30:03 -0300 (master branch) (Win64, RelWithDebInfo, Static)

Operating system

Windows 10 x64

Custom changes or Modules

No response

kjack9 commented 11 months ago

Looks like there may be a timing issue here. Vael's Reset() function sets the health to 30%, but it doesn't appear to happen before I change the health value. I will investigate.

image

kjack9 commented 11 months ago

Valithria Dreamwalker is actually working fine - starts at scaled 50% as intended. So I'll figure out what's different between them.

kjack9 commented 11 months ago

The latest push should fix this one too - my hacky fix for the other issue was causing this one.

https://github.com/kjack9/mod-autobalance/archive/refs/heads/kjack9/issue169.zip

Can you please test?

alca-00 commented 11 months ago

It works, Vaelastrasz has his health properly set to 30%! Entered a fresh BWL instance normally through UBRS and by using teleports, each time unbinding the instance to be sure.

Vael's HP is automatically set to 30%. Started the encounter and reset it, HP returns back to 30% as well. Seems good

kjack9 commented 11 months ago

Try this one more time: https://github.com/kjack9/mod-autobalance/archive/refs/heads/kjack9/issue169.zip

Tip: if you need a previous version from that branch, you can view the commits here: https://github.com/kjack9/mod-autobalance/commits/kjack9/issue169