search

azerothcore / mod-autobalance

Module for AzerothCore(MaNGOS -> TrinityCore -> SunwellCore)
http://www.azerothcore.org
102 stars 109 forks source link

Divide et impera #190

Closed kewinrausch closed 2 weeks ago

kewinrausch commented 3 weeks ago

Changes Proposed:

Issues Addressed:

SOURCE:

Tests Performed:

How to Test the Changes:

  1. Pull the changes
  2. Compile the server
  3. Enter and complete and instance; i did not touch internal module mechanism except for splitting the classes into multiple files and some decorations.

Take you time to confirm that the module work as intended. I'm personally performing additional tests to be sure the balancing is not affected. I expect no problem since i just moved code around files and did not touch the code inside the classes and procedures.

Helias commented 3 weeks ago

it's a big PR, not sure if I have the time to review it soon :(

kewinrausch commented 3 weeks ago

Do not worry, i have no rush or bad feelings about it. Take all the time you need. I will keep playing using this and test out if something is broken on my side.

Yehonal commented 2 weeks ago

I think we should merge this asap, maybe we can "versioning" this module and add to the readme the commit/link to the version before this as a stable version, and this will stay in "beta" until we ensured that everything is working

unless there's someone that wants to test it extensively right now, but I'm afraid that the more time we wait the worse it will be to resolve the conflicts with other incoming PRs

Helias commented 2 weeks ago

@kewinrausch you could add a note in the README.md about this PR, saying that from this PR the module could be "unstable" and we'll merge the PR ;-)

I appreciate the big effort here, this note it's only to keep track of this

kewinrausch commented 2 weeks ago

I did as you requested.

Wouldn't it be better to create also a tag or a branch pointing to the stable version right now? Once enough time has passed and enough test have been performed the branch can be removed to maintain only the master one.

Helias commented 2 weeks ago

done ✅