azerothcore / mod-cfbg

Cross-faction Battleground for AzerothCore
MIT License
14 stars 42 forks source link

feat: Allow players to choose the race they get morphed into #103

Closed Nyeriah closed 2 years ago

Nyeriah commented 2 years ago

Title ^

1) run the sql 2) set CFBG.RandomRaceSelection = 0 3) type .cfbg race <appropriate race for your faction/class>

Gultask commented 2 years ago

After a long long time trying to get modules to work and finally realizing that I had built it with the config set to 1, I was then able to take a look at it and it works well as far as I can see. Faction and class restrictions are being enforced, and there's the message that tells the player about the limitations with female models.

There's no error message when trying to choose undead/forsaken, it just says it's set to random and doesn't tell that the undead models are unavailable, it may lead a couple of tickets and people asking about it in the Discord or /world, but otherwise it's a very minor issue. The same can be said about the elves, I think a lot of people may not realize that they need to remove the space and will just type 'blood elf' or 'night elf', but just adding a mini-guide in #announcements mentioning that will be fine, I think.

I wouldn't know what else to test or what possible errors to look out for, so maybe I'd ask for another tester to make sure but from my end everything looks great 👍

Nyeriah commented 2 years ago

I tried to get the undead models to work but unfortunately this happens:

image

😢

I added a notice saying that the race is unavailable. I'll see what I can do about the spaces

Gultask commented 2 years ago

Ah! One more thing that I forgot. When I first tried to test I had the feature disabled in the .conf file by mistake, but I was still allowed to input the commands and it even told me that the selection was successful even though it had no effect in BGs.